Get rid of FrameSelection::setSelection() taking VisibleSelection

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1356 matching lines @@
       isEndOfParagraph(caret) ? caret : nextPositionOf(caret);
   VisiblePosition previous = previousPositionOf(next);
   if (next.deepEquivalent() == previous.deepEquivalent())
     return;
   previous = previousPositionOf(previous);
   if (!inSameParagraph(next, previous))
     return;
   const EphemeralRange range = makeRange(previous, next);
   if (range.isNull())
     return;
-  VisibleSelection newSelection = createVisibleSelection(
-      SelectionInDOMTree::Builder().setBaseAndExtent(range).build());
+  const SelectionInDOMTree newSelection =
+      SelectionInDOMTree::Builder().setBaseAndExtent(range).build();
 
   // Transpose the two characters.
   String text = plainText(range);
   if (text.length() != 2)
     return;
   String transposed = text.right(1) + text.left(1);
 
   // Select the two characters.
-  if (newSelection !=
+  if (createVisibleSelection(newSelection) !=
       frame().selection().computeVisibleSelectionInDOMTreeDeprecated())
     frame().selection().setSelection(newSelection);
 
   // Insert the transposed characters.
   // TODO(chongz): Once we add |InsertTranspose| in |InputEvent::InputType|, we
   // should use it instead of |InsertFromPaste|.
   replaceSelectionWithText(transposed, false, false,
                            InputEvent::InputType::InsertFromPaste);
 }
 
@@ skipping 361 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->trace(m_frame);
   visitor->trace(m_lastEditCommand);
   visitor->trace(m_undoStack);
   visitor->trace(m_mark);
   visitor->trace(m_typingStyle);
 }
 
 }  // namespace blink