Avoid name collision for secondsPerHour/secondsPerMinute

Avoid name collision for secondsPerHour/secondsPerMinute

There are other places declaring the names secondsPerHour
and secondsPerMinute. They don't collide right now, but by
moving these to a smaller namespace I can avoid collisions
in some experiments.

Review-Url: https://codereview.chromium.org/2730683004
Cr-Commit-Position: refs/heads/master@{#454384}
Committed: https://chromium.googlesource.com/chromium/src/+/00df836c1618826e2a15678305ef9a2ad024ce6d

[Daniel Bratell, 2017-03-02 15:42:04]

bratell@opera.com changed reviewers:
+ fs@opera.com

[Daniel Bratell, 2017-03-02 15:42:05]

PTAL

[fs, 2017-03-02 15:52:16]

lgtm

https://codereview.chromium.org/2730683004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp (right):

https://codereview.chromium.org/2730683004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp:260: const int
secondsPerMinute = 60;
Maybe just fold these into their (single) use instead. Or at least move them to
just before they are used.

https://codereview.chromium.org/2730683004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp (right):

https://codereview.chromium.org/2730683004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp:407: const double
secondsPerMillisecond = 0.001;
Ditto.

[Daniel Bratell, 2017-03-02 16:32:26]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-03-02 16:32:26]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2730683004/#ps20001
(title: "Addressed review comments.")

[commit-bot: I haz the power, 2017-03-02 16:32:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 18:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 18:11:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fs, 2017-03-02 18:30:53]

https://codereview.chromium.org/2730683004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp (right):

https://codereview.chromium.org/2730683004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp:442: const int
secondsPerHour = 3600;
This was double for a reason =)

[Daniel Bratell, 2017-03-02 19:53:16]

https://codereview.chromium.org/2730683004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp (right):

https://codereview.chromium.org/2730683004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp:442: const int
secondsPerHour = 3600;
On 2017/03/02 18:30:53, fs wrote:
> This was double for a reason =)

Seems that way. Are people using millions of hours?

[Daniel Bratell, 2017-03-02 19:55:18]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-03-02 19:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2730683004/#ps40001
(title: "Keep using double")

[commit-bot: I haz the power, 2017-03-02 19:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-02 20:05:05]

On 2017/03/02 at 19:53:16, bratell wrote:
>
https://codereview.chromium.org/2730683004/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp (right):
> 
>
https://codereview.chromium.org/2730683004/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp:442: const int
secondsPerHour = 3600;
> On 2017/03/02 18:30:53, fs wrote:
> > This was double for a reason =)
> 
> Seems that way. Are people using millions of hours?

Only mastodontfilms-Mats

[commit-bot: I haz the power, 2017-03-02 21:38:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488484518528000,
"parent_rev": "0a52f5a31e5b6a2b3faba076efc944d55d6c4a58", "commit_rev":
"00df836c1618826e2a15678305ef9a2ad024ce6d"}

[commit-bot: I haz the power, 2017-03-02 21:39:15]

Description was changed from

==========
Avoid name collision for secondsPerHour/secondsPerMinute

There are other places declaring the names secondsPerHour
and secondsPerMinute. They don't collide right now, but by
moving these to a smaller namespace I can avoid collisions
in some experiments.
==========

to

==========
Avoid name collision for secondsPerHour/secondsPerMinute

There are other places declaring the names secondsPerHour
and secondsPerMinute. They don't collide right now, but by
moving these to a smaller namespace I can avoid collisions
in some experiments.

Review-Url: https://codereview.chromium.org/2730683004
Cr-Commit-Position: refs/heads/master@{#454384}
Committed:
https://chromium.googlesource.com/chromium/src/+/00df836c1618826e2a15678305ef...
==========

[commit-bot: I haz the power, 2017-03-02 21:39:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/00df836c1618826e2a15678305ef...