Avoid name collision for secondsPerHour/secondsPerMinute

third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "core/html/track/vtt/VTTScanner.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/text/SegmentedString.h"
 #include "wtf/text/CharacterNames.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
-const double secondsPerHour = 3600;
-const double secondsPerMinute = 60;
-const double secondsPerMillisecond = 0.001;
 const unsigned fileIdentifierLength = 6;
 
 bool VTTParser::parseFloatPercentageValue(VTTScanner& valueScanner,
                                           float& percentage) {
   float number;
   if (!valueScanner.scanFloat(number))
     return false;
   // '%' must be present and at the end of the setting value.
   if (!valueScanner.scan('%'))
     return false;
@@ skipping 374 matching lines @@
   }
 
   // Steps 13 - 17 - Collect next sequence of 0-9 after '.' (must be 3 chars).
   int value4;
   if (!input.scan('.') || input.scanDigits(value4) != 3)
     return false;
   if (value2 > 59 || value3 > 59)
     return false;
 
   // Steps 18 - 19 - Calculate result.
+  const int secondsPerHour = 3600;

[fs, 2017/03/02 18:30:53]

This was double for a reason =)

[Daniel Bratell, 2017/03/02 19:53:16]

Seems that way. Are people using millions of hours?

+  const int secondsPerMinute = 60;
+  const double secondsPerMillisecond = 0.001;
   timeStamp = (value1 * secondsPerHour) + (value2 * secondsPerMinute) + value3 +
               (value4 * secondsPerMillisecond);
   return true;
 }
 
 static VTTNodeType tokenToNodeType(VTTToken& token) {
   switch (token.name().length()) {
     case 1:
       if (token.name()[0] == 'c')
         return VTTNodeTypeClass;
@@ skipping 104 matching lines @@
 }
 
 DEFINE_TRACE(VTTParser) {
   visitor->trace(m_document);
   visitor->trace(m_client);
   visitor->trace(m_cueList);
   visitor->trace(m_regionMap);
 }
 
 }  // namespace blink