Avoid name collision for secondsPerHour/secondsPerMinute

third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 13 matching lines @@
  */
 
 #include "core/html/MediaFragmentURIParser.h"
 
 #include "wtf/text/CString.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
-const int secondsPerHour = 3600;
-const int secondsPerMinute = 60;
 const unsigned nptIdentiferLength = 4;  // "npt:"
 
 static String collectDigits(const LChar* input,
                             unsigned length,
                             unsigned& position) {
   StringBuilder digits;
 
   // http://www.ietf.org/rfc/rfc2326.txt
   // DIGIT ; any positive number
   while (position < length && isASCIIDigit(input[position]))
@@ skipping 205 matching lines @@
   // specification of NPT RFC 2326.
   //
   // ; defined in RFC 2326
   // npt-sec       = 1*DIGIT [ "." *DIGIT ]
   // npt-hhmmss    = npt-hh ":" npt-mm ":" npt-ss [ "." *DIGIT]
   // npt-mmss      = npt-mm ":" npt-ss [ "." *DIGIT]
   // npt-hh        =   1*DIGIT     ; any positive number
   // npt-mm        =   2DIGIT      ; 0-59
   // npt-ss        =   2DIGIT      ; 0-59
 
+  const int secondsPerHour = 3600;
+  const int secondsPerMinute = 60;

[fs, 2017/03/02 15:52:15]

Maybe just fold these into their (single) use instead. Or at least move them to
just before they are used.

   String digits1 = collectDigits(timeString, length, offset);
   int value1 = digits1.toInt();
   if (offset >= length || timeString[offset] == ',') {
     time = value1;
     return true;
   }
 
   double fraction = 0;
   if (timeString[offset] == '.') {
     if (offset == length)
@@ skipping 38 matching lines @@
 
   if (offset < length && timeString[offset] == '.')
     fraction = collectFraction(timeString, length, offset).toDouble();
 
   time = (value1 * secondsPerHour) + (value2 * secondsPerMinute) + value3 +
          fraction;
   return true;
 }
 
 }  // namespace blink