Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

Issue 2730683004: Avoid name collision for secondsPerHour/secondsPerMinute (Closed)
Patch Set: Keep using double Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
diff --git a/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp b/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
index 6a487d6e1b8561c2a398685201dbb7e879db93f2..0b9410f7dd56d8c89e00ab8467251abe17ac1826 100644
--- a/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
+++ b/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
@@ -31,8 +31,6 @@
namespace blink {
-const int secondsPerHour = 3600;
-const int secondsPerMinute = 60;
const unsigned nptIdentiferLength = 4; // "npt:"
static String collectDigits(const LChar* input,
@@ -310,6 +308,8 @@ bool MediaFragmentURIParser::parseNPTTime(const LChar* timeString,
if (offset < length && timeString[offset] == '.')
fraction = collectFraction(timeString, length, offset).toDouble();
+ const int secondsPerHour = 3600;
+ const int secondsPerMinute = 60;
time = (value1 * secondsPerHour) + (value2 * secondsPerMinute) + value3 +
fraction;
return true;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698