Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2726603002: Drop some "using namespace" in WebKit/Source/html. (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop some "using namespace" in WebKit/Source/html. Drop some "using namespace" that are not used or not allowed by the coding standard. Review-Url: https://codereview.chromium.org/2726603002 Cr-Commit-Position: refs/heads/master@{#453964} Committed: https://chromium.googlesource.com/chromium/src/+/815482d233a6c1a9bab29f2e258f3bc75cdb7d77

Patch Set 1 #

Patch Set 2 : Updated to a newer origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M third_party/WebKit/Source/core/html/HTMLFontElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableCellElement.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/PickerIndicatorElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Daniel Bratell
Just some more cleaning up while removing conflicts between files. using namespace std is forbidden ...
3 years, 9 months ago (2017-02-28 17:29:00 UTC) #2
fs
lgtm
3 years, 9 months ago (2017-02-28 17:42:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726603002/1
3 years, 9 months ago (2017-02-28 20:42:25 UTC) #5
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/html/ImageDocument.cpp: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-02-28 23:48:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726603002/20001
3 years, 9 months ago (2017-03-01 15:41:59 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 17:49:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/815482d233a6c1a9bab29f2e258f...

Powered by Google App Engine
This is Rietveld 408576698