needsPaintInvalidation() should not return true for selection.

needsPaintInvalidation() should not return true for selection.

In [1] we introduced a paint invalidation constant for repainting
selection. needsPaintInvalidation() started to also return true when
only the selection needed paint invalidation. Callers of that method
assumes that true will cause at least a full element repaint which made
us skip setting the diff to invalidate the object and only invalidate
the selection in some cases. Instead, only return true for
PaintInvalidationObject and PaintInvalidationSubtree.

[1] https://crrev.com/eff357ef

R=mstensho@opera.com
BUG=697337
Review-Url: https://codereview.chromium.org/2727843004
Cr-Commit-Position: refs/heads/master@{#454564}
Committed: https://chromium.googlesource.com/chromium/src/+/c63e571885b21aa510dc323ecb1c5bc18f1ed29b

[rune, 2017-03-02 15:06:20]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 15:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 16:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 16:09:11]

Dry run: This issue passed the CQ dry run.

[rune, 2017-03-02 16:58:25]

ptal

[mstensho (USE GERRIT), 2017-03-02 19:35:26]

"[1]" in the description is undefined.

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleDifference.h (left):

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleDifference.h:54: bool
needsPaintInvalidation() const {
Shouldn't this be renamed to needsFullPaintInvalidation() or something then?

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleDifference.h (right):

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleDifference.h:55: return
m_paintInvalidationType > PaintInvalidationSelection;
... and to make it more obvious that selection invalidation isn't full
invalidation, perhaps the enum value should be named
PaintInvalidationSelectionOnly?

[rune, 2017-03-03 09:13:09]

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleDifference.h (left):

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleDifference.h:54: bool
needsPaintInvalidation() const {
On 2017/03/02 19:35:26, mstensho wrote:
> Shouldn't this be renamed to needsFullPaintInvalidation() or something then?

Done.

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/StyleDifference.h (right):

https://codereview.chromium.org/2727843004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/StyleDifference.h:55: return
m_paintInvalidationType > PaintInvalidationSelection;
On 2017/03/02 19:35:26, mstensho wrote:
> ... and to make it more obvious that selection invalidation isn't full
> invalidation, perhaps the enum value should be named
> PaintInvalidationSelectionOnly?

Done.

[rune, 2017-03-03 09:19:51]

Description was changed from

==========
needsPaintInvalidation() should not return true for selection.

In [1] we introduced a paint invalidation constant for repainting
selection. needsPaintInvalidation() started to also return true when
only the selection needed paint invalidation. Callers of that method
assumes that true will cause at least a full element repaint which made
us skip setting the diff to invalidate the object and only invalidate
the selection in some cases. Instead, only return true for
PaintInvalidationObject and PaintInvalidationSubtree.

R=mstensho@opera.com
BUG=697337
==========

to

==========
needsPaintInvalidation() should not return true for selection.

In [1] we introduced a paint invalidation constant for repainting
selection. needsPaintInvalidation() started to also return true when
only the selection needed paint invalidation. Callers of that method
assumes that true will cause at least a full element repaint which made
us skip setting the diff to invalidate the object and only invalidate
the selection in some cases. Instead, only return true for
PaintInvalidationObject and PaintInvalidationSubtree.

[1] https://crrev.com/eff357ef

R=mstensho@opera.com
BUG=697337
==========

[mstensho (USE GERRIT), 2017-03-03 09:20:39]

lgtm

[rune, 2017-03-03 09:21:27]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2017-03-03 09:21:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 11:12:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488532887100140,
"parent_rev": "a333b76c54e0058b23fa8f2ffb6a64dc53fbb6e1", "commit_rev":
"c63e571885b21aa510dc323ecb1c5bc18f1ed29b"}

[commit-bot: I haz the power, 2017-03-03 11:12:54]

Description was changed from

==========
needsPaintInvalidation() should not return true for selection.

In [1] we introduced a paint invalidation constant for repainting
selection. needsPaintInvalidation() started to also return true when
only the selection needed paint invalidation. Callers of that method
assumes that true will cause at least a full element repaint which made
us skip setting the diff to invalidate the object and only invalidate
the selection in some cases. Instead, only return true for
PaintInvalidationObject and PaintInvalidationSubtree.

[1] https://crrev.com/eff357ef

R=mstensho@opera.com
BUG=697337
==========

to

==========
needsPaintInvalidation() should not return true for selection.

In [1] we introduced a paint invalidation constant for repainting
selection. needsPaintInvalidation() started to also return true when
only the selection needed paint invalidation. Callers of that method
assumes that true will cause at least a full element repaint which made
us skip setting the diff to invalidate the object and only invalidate
the selection in some cases. Instead, only return true for
PaintInvalidationObject and PaintInvalidationSubtree.

[1] https://crrev.com/eff357ef

R=mstensho@opera.com
BUG=697337

Review-Url: https://codereview.chromium.org/2727843004
Cr-Commit-Position: refs/heads/master@{#454564}
Committed:
https://chromium.googlesource.com/chromium/src/+/c63e571885b21aa510dc323ecb1c...
==========

[commit-bot: I haz the power, 2017-03-03 11:12:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c63e571885b21aa510dc323ecb1c...