needsPaintInvalidation() should not return true for selection.

third_party/WebKit/Source/core/style/StyleDifference.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef StyleDifference_h
 #define StyleDifference_h
 
 #include "wtf/Allocator.h"
 #include "wtf/Assertions.h"
 
@@ skipping 33 matching lines @@
            (!m_recomputeOverflow && !m_scrollAnchorDisablingPropertyChanged));
     return result;
   }
 
   bool hasAtMostPropertySpecificDifferences(
       unsigned propertyDifferences) const {
     return !m_paintInvalidationType && !m_layoutType &&
            !(m_propertySpecificDifferences & ~propertyDifferences);
   }
 
   bool needsPaintInvalidation() const {

[mstensho (USE GERRIT), 2017/03/02 19:35:26]

Shouldn't this be renamed to needsFullPaintInvalidation() or something then?

[rune, 2017/03/03 09:13:09]

Done.

-    return m_paintInvalidationType != NoPaintInvalidation;
+    return m_paintInvalidationType > PaintInvalidationSelection;

[mstensho (USE GERRIT), 2017/03/02 19:35:26]

... and to make it more obvious that selection invalidation isn't full
invalidation, perhaps the enum value should be named
PaintInvalidationSelectionOnly?

[rune, 2017/03/03 09:13:09]

Done.

   }
 
   // The text selection needs paint invalidation.
   bool needsPaintInvalidationSelection() const {
     return m_paintInvalidationType == PaintInvalidationSelection;
   }
   void setNeedsPaintInvalidationSelection() {
     if (!needsPaintInvalidation())
       m_paintInvalidationType = PaintInvalidationSelection;
   }
@@ skipping 93 matching lines @@
   enum LayoutType { NoLayout = 0, PositionedMovement, FullLayout };
   unsigned m_layoutType : 2;
   unsigned m_recomputeOverflow : 1;
   unsigned m_propertySpecificDifferences : 7;
   unsigned m_scrollAnchorDisablingPropertyChanged : 1;
 };
 
 }  // namespace blink
 
 #endif  // StyleDifference_h