Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp

Issue 2727843004: needsPaintInvalidation() should not return true for selection. (Closed)
Patch Set: Renaming. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 } 204 }
205 205
206 void LayoutScrollbarPart::styleDidChange(StyleDifference diff, 206 void LayoutScrollbarPart::styleDidChange(StyleDifference diff,
207 const ComputedStyle* oldStyle) { 207 const ComputedStyle* oldStyle) {
208 LayoutBlock::styleDidChange(diff, oldStyle); 208 LayoutBlock::styleDidChange(diff, oldStyle);
209 // See adjustStyleBeforeSet() above. 209 // See adjustStyleBeforeSet() above.
210 ASSERT(!isOrthogonalWritingModeRoot()); 210 ASSERT(!isOrthogonalWritingModeRoot());
211 setInline(false); 211 setInline(false);
212 clearPositionedState(); 212 clearPositionedState();
213 setFloating(false); 213 setFloating(false);
214 if (oldStyle && (diff.needsPaintInvalidation() || diff.needsLayout())) 214 if (oldStyle && (diff.needsFullPaintInvalidation() || diff.needsLayout()))
215 setNeedsPaintInvalidation(); 215 setNeedsPaintInvalidation();
216 } 216 }
217 217
218 void LayoutScrollbarPart::imageChanged(WrappedImagePtr image, 218 void LayoutScrollbarPart::imageChanged(WrappedImagePtr image,
219 const IntRect* rect) { 219 const IntRect* rect) {
220 setNeedsPaintInvalidation(); 220 setNeedsPaintInvalidation();
221 LayoutBlock::imageChanged(image, rect); 221 LayoutBlock::imageChanged(image, rect);
222 } 222 }
223 223
224 LayoutObject* LayoutScrollbarPart::scrollbarStyleSource() const { 224 LayoutObject* LayoutScrollbarPart::scrollbarStyleSource() const {
(...skipping 12 matching lines...) Expand all
237 if (frameView->isFrameViewScrollCorner(this)) { 237 if (frameView->isFrameViewScrollCorner(this)) {
238 frameView->setScrollCornerNeedsPaintInvalidation(); 238 frameView->setScrollCornerNeedsPaintInvalidation();
239 return; 239 return;
240 } 240 }
241 } 241 }
242 242
243 m_scrollableArea->setScrollCornerNeedsPaintInvalidation(); 243 m_scrollableArea->setScrollCornerNeedsPaintInvalidation();
244 } 244 }
245 245
246 } // namespace blink 246 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698