Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: third_party/WebKit/Source/core/style/StyleDifference.h

Issue 2727843004: needsPaintInvalidation() should not return true for selection. (Closed)
Patch Set: Renaming. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/StyleDifference.h
diff --git a/third_party/WebKit/Source/core/style/StyleDifference.h b/third_party/WebKit/Source/core/style/StyleDifference.h
index a646e54bb1e584102df98292b2971d1198e628bc..1c622066d032d997f67430b0d18cdcf846974a0f 100644
--- a/third_party/WebKit/Source/core/style/StyleDifference.h
+++ b/third_party/WebKit/Source/core/style/StyleDifference.h
@@ -51,17 +51,17 @@ class StyleDifference {
!(m_propertySpecificDifferences & ~propertyDifferences);
}
- bool needsPaintInvalidation() const {
- return m_paintInvalidationType != NoPaintInvalidation;
+ bool needsFullPaintInvalidation() const {
+ return m_paintInvalidationType > PaintInvalidationSelectionOnly;
}
// The text selection needs paint invalidation.
bool needsPaintInvalidationSelection() const {
- return m_paintInvalidationType == PaintInvalidationSelection;
+ return m_paintInvalidationType == PaintInvalidationSelectionOnly;
}
void setNeedsPaintInvalidationSelection() {
- if (!needsPaintInvalidation())
- m_paintInvalidationType = PaintInvalidationSelection;
+ if (!needsFullPaintInvalidation())
+ m_paintInvalidationType = PaintInvalidationSelectionOnly;
}
// The object just needs to issue paint invalidations.
@@ -150,7 +150,7 @@ class StyleDifference {
private:
enum PaintInvalidationType {
NoPaintInvalidation,
- PaintInvalidationSelection,
+ PaintInvalidationSelectionOnly,
PaintInvalidationObject,
PaintInvalidationSubtree,
};
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698