Call getUncachedPseudoStyle on correct node for ::selection.

Call getUncachedPseudoStyle on correct node for ::selection.

getUncachedSelectionStyle is typically called for the LayoutObject we
are currently painting. This might not be the node the ::selection
style is matched for. Specifically, we request getUncachedSelectionStyle
on LayoutText objects, but we need to match the ::selection style on its
parent element.

This already happened inside getUncachedPseudoStyle, but it's guarded by
a hasPseudoStyle() call for the pseudo element type. In the case where
we pass in a LayoutText, we are relying on the computed style with the
PseudoIdSelection bit set to be propagated down to the LayoutText object.
That does not happen if the style change for the element parent is
NoChange or NoInherit.

Instead find the element for which we are matching ::selection in
getUncachedSelectionStyle instead. The firstAncestorOrSelf() call is
still present in getUncachedPseudoStyle as there may be other pseudo
elements types where we rely on this.

R=mstensho@opera.com
BUG=685174
Review-Url: https://codereview.chromium.org/2727253004
Cr-Commit-Position: refs/heads/master@{#454575}
Committed: https://chromium.googlesource.com/chromium/src/+/aac53af022b711ae7d4db563221a06be9f070e82

[rune, 2017-03-03 10:58:17]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 10:58:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2017-03-03 10:58:35]

ptal

[mstensho (USE GERRIT), 2017-03-03 12:06:35]

lgtm

https://codereview.chromium.org/2727253004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2727253004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3075: // we use calculate
::selection style on the shadow host for elements inside
I have problems parsing the sentence. -"use"?

https://codereview.chromium.org/2727253004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3087: // the parent
element instead as that is the node for which ::selection
Needs moar comma. Before "as"?

[rune, 2017-03-03 12:13:57]

https://codereview.chromium.org/2727253004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2727253004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3075: // we use calculate
::selection style on the shadow host for elements inside
On 2017/03/03 12:06:34, mstensho wrote:
> I have problems parsing the sentence. -"use"?

Done.

https://codereview.chromium.org/2727253004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3087: // the parent
element instead as that is the node for which ::selection
On 2017/03/03 12:06:34, mstensho wrote:
> Needs moar comma. Before "as"?

Done.

[rune, 2017-03-03 12:14:03]

The CQ bit was checked by rune@opera.com

[rune, 2017-03-03 12:14:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2727253004/#ps20001
(title: "Documentation fixes.")

[commit-bot: I haz the power, 2017-03-03 12:14:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 13:55:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488543243534170,
"parent_rev": "53d6164849152e6a3ef16279d0b6da513bf8e9d4", "commit_rev":
"aac53af022b711ae7d4db563221a06be9f070e82"}

[commit-bot: I haz the power, 2017-03-03 13:56:05]

Description was changed from

==========
Call getUncachedPseudoStyle on correct node for ::selection.

getUncachedSelectionStyle is typically called for the LayoutObject we
are currently painting. This might not be the node the ::selection
style is matched for. Specifically, we request getUncachedSelectionStyle
on LayoutText objects, but we need to match the ::selection style on its
parent element.

This already happened inside getUncachedPseudoStyle, but it's guarded by
a hasPseudoStyle() call for the pseudo element type. In the case where
we pass in a LayoutText, we are relying on the computed style with the
PseudoIdSelection bit set to be propagated down to the LayoutText object.
That does not happen if the style change for the element parent is
NoChange or NoInherit.

Instead find the element for which we are matching ::selection in
getUncachedSelectionStyle instead. The firstAncestorOrSelf() call is
still present in getUncachedPseudoStyle as there may be other pseudo
elements types where we rely on this.

R=mstensho@opera.com
BUG=685174
==========

to

==========
Call getUncachedPseudoStyle on correct node for ::selection.

getUncachedSelectionStyle is typically called for the LayoutObject we
are currently painting. This might not be the node the ::selection
style is matched for. Specifically, we request getUncachedSelectionStyle
on LayoutText objects, but we need to match the ::selection style on its
parent element.

This already happened inside getUncachedPseudoStyle, but it's guarded by
a hasPseudoStyle() call for the pseudo element type. In the case where
we pass in a LayoutText, we are relying on the computed style with the
PseudoIdSelection bit set to be propagated down to the LayoutText object.
That does not happen if the style change for the element parent is
NoChange or NoInherit.

Instead find the element for which we are matching ::selection in
getUncachedSelectionStyle instead. The firstAncestorOrSelf() call is
still present in getUncachedPseudoStyle as there may be other pseudo
elements types where we rely on this.

R=mstensho@opera.com
BUG=685174

Review-Url: https://codereview.chromium.org/2727253004
Cr-Commit-Position: refs/heads/master@{#454575}
Committed:
https://chromium.googlesource.com/chromium/src/+/aac53af022b711ae7d4db563221a...
==========

[commit-bot: I haz the power, 2017-03-03 13:56:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aac53af022b711ae7d4db563221a...