Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

BUG=596760
Review-Url: https://codereview.chromium.org/2727843003
Cr-Commit-Position: refs/heads/master@{#454217}
Committed: https://chromium.googlesource.com/chromium/src/+/020397fbdf70bb4398dab310bccb437ba5b2377a

[tkent, 2017-03-02 03:21:41]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 03:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 03:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 03:45:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2017-03-02 04:02:21]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2017-03-02 04:02:41]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-02 04:04:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-02 05:58:31]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org

[tkent, 2017-03-02 05:58:32]

yoichio@, would you review this please?

[yoichio, 2017-03-02 07:25:22]

https://codereview.chromium.org/2727843003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right):

https://codereview.chromium.org/2727843003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:70:
CHECK(newThresholdIndex < kMaxThresholdIndex);
CHECK_LT?

[tkent, 2017-03-02 07:33:59]

https://codereview.chromium.org/2727843003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right):

https://codereview.chromium.org/2727843003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:70:
CHECK(newThresholdIndex < kMaxThresholdIndex);
On 2017/03/02 at 07:25:22, yoichio wrote:
> CHECK_LT?

Unfortunately we can't.  If we use CHECK_LT, IntersectionObservation.cpp can't
be compiled due to a missing symbol.
I didn't investigate the root cause because this change isn't so important.

[yoichio, 2017-03-02 07:35:50]

On 2017/03/02 07:33:59, tkent wrote:
>
https://codereview.chromium.org/2727843003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/IntersectionObservation.cpp (right):
> 
>
https://codereview.chromium.org/2727843003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/IntersectionObservation.cpp:70:
> CHECK(newThresholdIndex < kMaxThresholdIndex);
> On 2017/03/02 at 07:25:22, yoichio wrote:
> > CHECK_LT?
> 
> Unfortunately we can't.  If we use CHECK_LT, IntersectionObservation.cpp can't
> be compiled due to a missing symbol.
> I didn't investigate the root cause because this change isn't so important.

lgtm if you comment out it on code.

[commit-bot: I haz the power, 2017-03-02 07:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 07:43:50]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-02 08:03:12]

> lgtm if you comment out it on code.

Done.

[tkent, 2017-03-02 08:03:15]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-02 08:03:15]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2727843003/#ps40001
(title: "Add a comment")

[commit-bot: I haz the power, 2017-03-02 08:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 09:18:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488441795321420,
"parent_rev": "a2d8556be5121f4c6640443f5a5c549ba450c770", "commit_rev":
"020397fbdf70bb4398dab310bccb437ba5b2377a"}

[commit-bot: I haz the power, 2017-03-02 09:19:07]

Description was changed from

==========
Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

BUG=596760
==========

to

==========
Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

BUG=596760

Review-Url: https://codereview.chromium.org/2727843003
Cr-Commit-Position: refs/heads/master@{#454217}
Committed:
https://chromium.googlesource.com/chromium/src/+/020397fbdf70bb4398dab310bccb...
==========

[commit-bot: I haz the power, 2017-03-02 09:19:08]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/020397fbdf70bb4398dab310bccb...