third_party/WebKit/Source/core/editing/serializers/Serialization.cpp - Issue 2727843003: Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

Issue 2727843003: Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html} (Closed)

Patch Set: Add a comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp ('k') | third_party/WebKit/Source/core/html/ImageDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

index 794b7cedd64da049c5e3a5630dec9f97d295c63d..5619d25c099c6d1bfb4f5ada3ac584a06c1d6ef3 100644

--- a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

@@ -263,7 +263,7 @@ String CreateMarkupAlgorithm<Strategy>::createMarkup(

if (startPosition.isNull() || endPosition.isNull())

return emptyString;

- RELEASE_ASSERT(startPosition.compareTo(endPosition) <= 0);

+ CHECK_LE(startPosition.compareTo(endPosition), 0);

bool collapsed = startPosition == endPosition;

if (collapsed)