Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2727843003: Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html} (Closed)
Patch Set: Add a comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index c982b4087309b84ced1b36b5c44fd5b5da95f9d4..e5133f38020307248256795ba97ccedbded80648 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -1182,7 +1182,7 @@ Node* Document::adoptNode(Node* source, ExceptionState& exceptionState) {
source->parentNode()->removeChild(source, exceptionState);
if (exceptionState.hadException())
return nullptr;
- RELEASE_ASSERT(!source->parentNode());
+ CHECK(!source->parentNode());
}
}
@@ -1991,7 +1991,7 @@ void Document::updateStyleAndLayoutTree() {
// recalcStyle can tear down the layout tree or (unfortunately) run
// script. Kill the whole layoutObject if someone managed to get into here in
// states not allowing tree mutations.
- RELEASE_ASSERT(lifecycle().stateAllowsTreeMutations());
+ CHECK(lifecycle().stateAllowsTreeMutations());
TRACE_EVENT_BEGIN1("blink,devtools.timeline", "UpdateLayoutTree", "beginData",
InspectorRecalculateStylesEvent::data(frame()));
@@ -2446,7 +2446,7 @@ void Document::initialize() {
void Document::shutdown() {
TRACE_EVENT0("blink", "Document::shutdown");
- RELEASE_ASSERT(!m_frame || m_frame->tree().childCount() == 0);
+ CHECK(!m_frame || m_frame->tree().childCount() == 0);
if (!isActive())
return;
« no previous file with comments | « third_party/WebKit/Source/core/dom/DOMDataView.cpp ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698