third_party/WebKit/Source/core/dom/DOMDataView.cpp - Issue 2727843003: Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMDataView.cpp

Issue 2727843003: Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html} (Closed)

Patch Set: Add a comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMDataView.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMDataView.cpp b/third_party/WebKit/Source/core/dom/DOMDataView.cpp

index 58763a9059c09828bbab5d70052df402b6cff594..99a53e8b4f9f9fa8bd472aebd8f658cf39e6a52f 100644

--- a/third_party/WebKit/Source/core/dom/DOMDataView.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMDataView.cpp

@@ -20,7 +20,7 @@ class DataView final : public ArrayBufferView {

unsigned byteLength) {

CheckedNumeric<uint32_t> checkedMax = byteOffset;

checkedMax += byteLength;

- RELEASE_ASSERT(checkedMax.ValueOrDie() <= buffer->byteLength());

+ CHECK_LE(checkedMax.ValueOrDie(), buffer->byteLength());

return adoptRef(new DataView(buffer, byteOffset, byteLength));

}