Replace RELEASE_ASSERT with CHECK in core/{dom,editing,html}

third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/IntersectionObservation.h"
 
 #include "core/dom/ElementRareData.h"
 #include "core/dom/IntersectionObserver.h"
 #include "core/layout/IntersectionGeometry.h"
 
@@ skipping 49 matching lines @@
       float targetArea = geometry.targetRect().size().width().toFloat() *
                          geometry.targetRect().size().height().toFloat();
       newVisibleRatio = intersectionArea / targetArea;
     }
     newThresholdIndex = observer()->firstThresholdGreaterThan(newVisibleRatio);
   } else {
     newVisibleRatio = 0;
     newThresholdIndex = 0;
   }
 
-  RELEASE_ASSERT(newThresholdIndex < kMaxThresholdIndex);
+  CHECK(newThresholdIndex < kMaxThresholdIndex);

[yoichio, 2017/03/02 07:25:22]

CHECK_LT?

[tkent, 2017/03/02 07:33:59]

Unfortunately we can't.  If we use CHECK_LT, IntersectionObservation.cpp can't
be compiled due to a missing symbol.
I didn't investigate the root cause because this change isn't so important.

 
   if (m_lastThresholdIndex != newThresholdIndex) {
     IntRect snappedRootBounds = geometry.rootIntRect();
     IntRect* rootBoundsPointer =
         m_shouldReportRootBounds ? &snappedRootBounds : nullptr;
     IntersectionObserverEntry* newEntry = new IntersectionObserverEntry(
         timestamp, newVisibleRatio, geometry.targetIntRect(), rootBoundsPointer,
         geometry.intersectionIntRect(), geometry.doesIntersect(), target());
     observer()->enqueueIntersectionObserverEntry(*newEntry);
     setLastThresholdIndex(newThresholdIndex);
   }
 }
 
 void IntersectionObservation::disconnect() {
   DCHECK(observer());
   if (m_target)
     target()->ensureIntersectionObserverData().removeObservation(*observer());
   m_observer.clear();
 }
 
 DEFINE_TRACE(IntersectionObservation) {
   visitor->trace(m_observer);
   visitor->trace(m_target);
 }
 
 }  // namespace blink