Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2724243002: Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/. BUG=596760 Review-Url: https://codereview.chromium.org/2724243002 Cr-Commit-Position: refs/heads/master@{#454205} Committed: https://chromium.googlesource.com/chromium/src/+/779cca685c355ea3201ffbef39dfd56b37520d29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/core/testing/DictionaryTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/GCObservation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/UnionTypesTest.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yoichio@, would you review this please?
3 years, 9 months ago (2017-03-02 05:58:52 UTC) #6
yoichio
lgtm
3 years, 9 months ago (2017-03-02 07:26:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724243002/1
3 years, 9 months ago (2017-03-02 07:36:00 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 07:41:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/779cca685c355ea3201ffbef39df...

Powered by Google App Engine
This is Rietveld 408576698