Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/core/testing/GCObservation.cpp

Issue 2724243002: Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #include "core/testing/GCObservation.h" 31 #include "core/testing/GCObservation.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 static void setWeakCallbackForGCObservation( 35 static void setWeakCallbackForGCObservation(
36 const v8::WeakCallbackInfo<GCObservation>& data) { 36 const v8::WeakCallbackInfo<GCObservation>& data) {
37 data.GetParameter()->setWasCollected(); 37 data.GetParameter()->setWasCollected();
38 } 38 }
39 39
40 void GCObservation::setWasCollected() { 40 void GCObservation::setWasCollected() {
41 ASSERT(!wasCollected()); 41 DCHECK(!wasCollected());
42 m_observed.clear(); 42 m_observed.clear();
43 m_collected = true; 43 m_collected = true;
44 } 44 }
45 45
46 GCObservation::GCObservation(v8::Local<v8::Value> observedValue) 46 GCObservation::GCObservation(v8::Local<v8::Value> observedValue)
47 : m_observed(v8::Isolate::GetCurrent(), observedValue), m_collected(false) { 47 : m_observed(v8::Isolate::GetCurrent(), observedValue), m_collected(false) {
48 m_observed.setWeak(this, setWeakCallbackForGCObservation); 48 m_observed.setWeak(this, setWeakCallbackForGCObservation);
49 } 49 }
50 50
51 } // namespace blink 51 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/testing/DummyPageHolder.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698