Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp

Issue 2724243002: Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/testing/UnionTypesTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp
diff --git a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp
index 0339a641ce4ec7b1e28038caac5e6b3271c979c3..f21b850c39719ca729692add25b043c775407b1c 100644
--- a/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp
+++ b/third_party/WebKit/Source/core/testing/v8/WebCoreTestSupport.cpp
@@ -111,14 +111,14 @@ void resetInternalsObject(v8::Local<v8::Context> context) {
blink::ScriptState* scriptState = blink::ScriptState::from(context);
blink::ScriptState::Scope scope(scriptState);
blink::Document* document = toDocument(scriptState->getExecutionContext());
- ASSERT(document);
+ DCHECK(document);
blink::LocalFrame* frame = document->frame();
// Should the document have been detached, the page is assumed being destroyed
// (=> no reset required.)
if (!frame)
return;
blink::Page* page = frame->page();
- ASSERT(page);
+ DCHECK(page);
blink::Internals::resetToConsistentState(page);
blink::InternalSettings::from(*page)->resetToConsistentState();
}
« no previous file with comments | « third_party/WebKit/Source/core/testing/UnionTypesTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698