third_party/WebKit/Source/core/testing/DictionaryTest.cpp - Issue 2724243002: Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

Issue 2724243002: Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

diff --git a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

index 6a73fe1132f3f32f1b03dfc0e99dd4e31b2a6387..e917501c1cf50992e5704d4d0a293846c8b7114f 100644

--- a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

+++ b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

@@ -137,7 +137,7 @@ ScriptValue DictionaryTest::getDictionaryMemberProperties(

}

void DictionaryTest::setDerived(const InternalDictionaryDerived& derived) {

- ASSERT(derived.hasRequiredBooleanMember());

+ DCHECK(derived.hasRequiredBooleanMember());

set(derived);

if (derived.hasDerivedStringMember())

m_derivedStringMember = derived.derivedStringMember();

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/testing/DummyPageHolder.cpp » ('j') | no next file with comments »