Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: third_party/WebKit/Source/core/testing/Internals.cpp

Issue 2724243002: Replace ASSERT and ASSERT_NOT_REACHED with DCHECK and NOTREACHED in core/testing/. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 switch (toShadowRoot(root)->type()) { 805 switch (toShadowRoot(root)->type()) {
806 case ShadowRootType::UserAgent: 806 case ShadowRootType::UserAgent:
807 return String("UserAgentShadowRoot"); 807 return String("UserAgentShadowRoot");
808 case ShadowRootType::V0: 808 case ShadowRootType::V0:
809 return String("V0ShadowRoot"); 809 return String("V0ShadowRoot");
810 case ShadowRootType::Open: 810 case ShadowRootType::Open:
811 return String("OpenShadowRoot"); 811 return String("OpenShadowRoot");
812 case ShadowRootType::Closed: 812 case ShadowRootType::Closed:
813 return String("ClosedShadowRoot"); 813 return String("ClosedShadowRoot");
814 default: 814 default:
815 ASSERT_NOT_REACHED(); 815 NOTREACHED();
816 return String("Unknown"); 816 return String("Unknown");
817 } 817 }
818 } 818 }
819 819
820 const AtomicString& Internals::shadowPseudoId(Element* element) { 820 const AtomicString& Internals::shadowPseudoId(Element* element) {
821 DCHECK(element); 821 DCHECK(element);
822 return element->shadowPseudoId(); 822 return element->shadowPseudoId();
823 } 823 }
824 824
825 String Internals::visiblePlaceholder(Element* element) { 825 String Internals::visiblePlaceholder(Element* element) {
(...skipping 1730 matching lines...) Expand 10 before | Expand all | Expand 10 after
2556 case Cursor::ZoomOut: 2556 case Cursor::ZoomOut:
2557 return "ZoomOut"; 2557 return "ZoomOut";
2558 case Cursor::Grab: 2558 case Cursor::Grab:
2559 return "Grab"; 2559 return "Grab";
2560 case Cursor::Grabbing: 2560 case Cursor::Grabbing:
2561 return "Grabbing"; 2561 return "Grabbing";
2562 case Cursor::Custom: 2562 case Cursor::Custom:
2563 return "Custom"; 2563 return "Custom";
2564 } 2564 }
2565 2565
2566 ASSERT_NOT_REACHED(); 2566 NOTREACHED();
2567 return "UNKNOWN"; 2567 return "UNKNOWN";
2568 } 2568 }
2569 2569
2570 String Internals::getCurrentCursorInfo() { 2570 String Internals::getCurrentCursorInfo() {
2571 if (!frame()) 2571 if (!frame())
2572 return String(); 2572 return String();
2573 2573
2574 Cursor cursor = frame()->page()->chromeClient().lastSetCursorForTesting(); 2574 Cursor cursor = frame()->page()->chromeClient().lastSetCursorForTesting();
2575 2575
2576 StringBuilder result; 2576 StringBuilder result;
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
3176 3176
3177 void Internals::crash() { 3177 void Internals::crash() {
3178 CHECK(false) << "Intentional crash"; 3178 CHECK(false) << "Intentional crash";
3179 } 3179 }
3180 3180
3181 void Internals::setIsLowEndDevice(bool isLowEndDevice) { 3181 void Internals::setIsLowEndDevice(bool isLowEndDevice) {
3182 MemoryCoordinator::setIsLowEndDeviceForTesting(isLowEndDevice); 3182 MemoryCoordinator::setIsLowEndDeviceForTesting(isLowEndDevice);
3183 } 3183 }
3184 3184
3185 } // namespace blink 3185 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/testing/GCObservation.cpp ('k') | third_party/WebKit/Source/core/testing/UnionTypesTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698