Description was changed from ========== [WIP] List site in password settings Design doc: go/jgdrc TODO: ...
3 years, 9 months ago
(2017-02-28 20:30:10 UTC)
#1
Description was changed from
==========
[WIP] List site in password settings
Design doc: go/jgdrc
TODO: Tests to be done.
BUG=159166
==========
to
==========
[WIP] List site in password settings
Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39
TODO: Tests to be done.
BUG=159166
==========
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
3 years, 7 months ago
(2017-05-01 18:10:53 UTC)
#2
Description was changed from ========== [WIP] List site in password settings Design doc: go/jgdrc, screenshots ...
3 years, 7 months ago
(2017-05-01 18:30:56 UTC)
#4
Description was changed from
==========
[WIP] List site in password settings
Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39
TODO: Tests to be done.
BUG=159166
==========
to
==========
List site in password settings
Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39
This also marks a lot of constants indeed as const in the unittest, and removes
one leak (allocation of PasswordForm by new without calling delete on it).
BUG=159166
==========
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
3 years, 7 months ago
(2017-05-01 18:45:25 UTC)
#5
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/435075)
3 years, 7 months ago
(2017-05-03 08:48:23 UTC)
#15
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493803719311940, "parent_rev": "2e1c1951bdfd584c7b076020071ff2596d89d909", "commit_rev": "b9e34e34713840faca51b983fdd99cf6288e9204"}
3 years, 7 months ago
(2017-05-03 09:41:53 UTC)
#19
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493803719311940,
"parent_rev": "2e1c1951bdfd584c7b076020071ff2596d89d909", "commit_rev":
"b9e34e34713840faca51b983fdd99cf6288e9204"}
commit-bot: I haz the power
Description was changed from ========== List site in password settings Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39 ...
3 years, 7 months ago
(2017-05-03 09:42:04 UTC)
#20
Message was sent while issue was closed.
Description was changed from
==========
List site in password settings
Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39
This also marks a lot of constants indeed as const in the unittest, and removes
one leak (allocation of PasswordForm by new without calling delete on it).
BUG=159166
==========
to
==========
List site in password settings
Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39
This also marks a lot of constants indeed as const in the unittest, and removes
one leak (allocation of PasswordForm by new without calling delete on it).
BUG=159166
Review-Url: https://codereview.chromium.org/2722853003
Cr-Commit-Position: refs/heads/master@{#468927}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9e34e34713840faca51b983fdd9...
==========
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/b9e34e34713840faca51b983fdd99cf6288e9204
3 years, 7 months ago
(2017-05-03 09:42:05 UTC)
#21
Issue 2722853003: List site in password settings
(Closed)
Created 3 years, 9 months ago by vabr (Chromium)
Modified 3 years, 7 months ago
Reviewers: lpromero
Base URL:
Comments: 0