List site in password settings

List site in password settings

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

This also marks a lot of constants indeed as const in the unittest, and removes one leak (allocation of PasswordForm by new without calling delete on it).

BUG=159166
Review-Url: https://codereview.chromium.org/2722853003
Cr-Commit-Position: refs/heads/master@{#468927}
Committed: https://chromium.googlesource.com/chromium/src/+/b9e34e34713840faca51b983fdd99cf6288e9204

[vabr (Chromium), 2017-02-28 20:30:10]

Description was changed from

==========
[WIP] List site in password settings

Design doc: go/jgdrc

TODO: Tests to be done.

BUG=159166
==========

to

==========
[WIP] List site in password settings

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

TODO: Tests to be done.

BUG=159166
==========

[vabr (Chromium), 2017-05-01 18:10:53]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:11:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-05-01 18:30:56]

Description was changed from

==========
[WIP] List site in password settings

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

TODO: Tests to be done.

BUG=159166
==========

to

==========
List site in password settings

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

This also marks a lot of constants indeed as const in the unittest, and removes
one leak (allocation of PasswordForm by new without calling delete on it).

BUG=159166
==========

[vabr (Chromium), 2017-05-01 18:45:25]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:46:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-05-01 18:50:34]

vabr@chromium.org changed reviewers:
+ lpromero@chromium.org

[vabr (Chromium), 2017-05-01 18:50:35]

Hi lpromero@,

This is CL 2/3 from the series. Please review at your leisure.

Cheers,
Vaclav

[commit-bot: I haz the power, 2017-05-01 19:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:50:41]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-05-02 16:35:00]

lgtm

[vabr (Chromium), 2017-05-03 08:40:41]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 08:40:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 08:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 08:48:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vabr (Chromium), 2017-05-03 09:28:39]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-05-03 09:28:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2722853003/#ps80001
(title: "Just rebased")

[commit-bot: I haz the power, 2017-05-03 09:28:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 09:41:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493803719311940,
"parent_rev": "2e1c1951bdfd584c7b076020071ff2596d89d909", "commit_rev":
"b9e34e34713840faca51b983fdd99cf6288e9204"}

[commit-bot: I haz the power, 2017-05-03 09:42:04]

Description was changed from

==========
List site in password settings

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

This also marks a lot of constants indeed as const in the unittest, and removes
one leak (allocation of PasswordForm by new without calling delete on it).

BUG=159166
==========

to

==========
List site in password settings

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

This also marks a lot of constants indeed as const in the unittest, and removes
one leak (allocation of PasswordForm by new without calling delete on it).

BUG=159166

Review-Url: https://codereview.chromium.org/2722853003
Cr-Commit-Position: refs/heads/master@{#468927}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9e34e34713840faca51b983fdd9...
==========

[commit-bot: I haz the power, 2017-05-03 09:42:05]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b9e34e34713840faca51b983fdd9...