Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm

Issue 2722853003: List site in password settings (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
index 4c629e24cb5fd973f6a1b9c0ac32adae66b62198..112b9623e19600e4649b858f95e443ddf375d039 100644
--- a/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
+++ b/ios/chrome/browser/ui/settings/password_details_collection_view_controller_unittest.mm
@@ -66,18 +66,23 @@
namespace {
-NSString* kUsername = @"testusername";
-NSString* kPassword = @"testpassword";
+NSString* const kSite = @"https://testorigin.com/";
+NSString* const kUsername = @"testusername";
+NSString* const kPassword = @"testpassword";
-int kUsernameSection = 0;
-int kUsernameItem = 0;
-int kCopyUsernameButtonItem = 1;
+const int kSiteSection = 0;
+const int kSiteItem = 0;
+const int kCopySiteButtonItem = 1;
-int kPasswordSection = 1;
-int kPasswordItem = 0;
-int kShowHideButtonItem = 1;
-int kCopyPasswordButtonItem = 2;
-int kDeleteButtonItem = 3;
+const int kUsernameSection = 1;
+const int kUsernameItem = 0;
+const int kCopyUsernameButtonItem = 1;
+
+const int kPasswordSection = 2;
+const int kPasswordItem = 0;
+const int kShowHideButtonItem = 1;
+const int kCopyPasswordButtonItem = 2;
+const int kDeleteButtonItem = 3;
class PasswordDetailsCollectionViewControllerTest
: public CollectionViewControllerTest {
@@ -86,14 +91,19 @@ class PasswordDetailsCollectionViewControllerTest
: thread_bundle_(web::TestWebThreadBundle::REAL_DB_THREAD) {}
void SetUp() override {
CollectionViewControllerTest::SetUp();
- origin_ = @"testorigin.com";
+ origin_ = kSite;
delegate_ = [[MockSavePasswordsCollectionViewController alloc] init];
reauthenticationModule_ = [[MockReauthenticationModule alloc] init];
}
CollectionViewController* InstantiateController() override {
+ autofill::PasswordForm form;
+ form.username_value = base::SysNSStringToUTF16(kUsername);
+ form.password_value = base::SysNSStringToUTF16(kPassword);
+ form.signon_realm = base::SysNSStringToUTF8(origin_);
+ form.origin = GURL(form.signon_realm);
return [[PasswordDetailsCollectionViewController alloc]
- initWithPasswordForm:*(new autofill::PasswordForm())
+ initWithPasswordForm:form
delegate:delegate_
reauthenticationModule:reauthenticationModule_
username:kUsername
@@ -115,7 +125,16 @@ class PasswordDetailsCollectionViewControllerTest
TEST_F(PasswordDetailsCollectionViewControllerTest, TestInitialization) {
CreateController();
CheckController();
- EXPECT_EQ(2, NumberOfSections());
+ EXPECT_EQ(3, NumberOfSections());
+ // Site section
+ EXPECT_EQ(2, NumberOfItemsInSection(kUsernameSection));
+ CheckSectionHeaderWithId(IDS_IOS_SHOW_PASSWORD_VIEW_SITE, kSiteSection);
+ PasswordDetailsItem* siteItem =
+ GetCollectionViewItem(kSiteSection, kSiteItem);
+ EXPECT_NSEQ(origin_, siteItem.text);
+ EXPECT_TRUE(siteItem.showingText);
+ CheckTextCellTitleWithId(IDS_IOS_SETTINGS_SITE_COPY_BUTTON, kSiteSection,
+ kCopySiteButtonItem);
// Username section
EXPECT_EQ(2, NumberOfItemsInSection(kUsernameSection));
CheckSectionHeaderWithId(IDS_IOS_SHOW_PASSWORD_VIEW_USERNAME,
@@ -162,6 +181,15 @@ TEST_F(PasswordDetailsCollectionViewControllerTest, SimplifyOrigin) {
}
}
+TEST_F(PasswordDetailsCollectionViewControllerTest, CopySite) {
+ CreateController();
+ [controller() collectionView:[controller() collectionView]
+ didSelectItemAtIndexPath:[NSIndexPath indexPathForRow:kCopySiteButtonItem
+ inSection:kSiteSection]];
+ UIPasteboard* generalPasteboard = [UIPasteboard generalPasteboard];
+ EXPECT_NSEQ(origin_, generalPasteboard.string);
+}
+
TEST_F(PasswordDetailsCollectionViewControllerTest, CopyUsername) {
CreateController();
[controller() collectionView:[controller() collectionView]

Powered by Google App Engine
This is Rietveld 408576698