Separate deletion button in password settings

Separate deletion button in password settings

The "Delete this password" button gets a separate section. Before this CL it
shares the section with the password value (separate from username and site),
but the deletion affects the whole credential, so it should be separate.

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c40

BUG=159166
Review-Url: https://codereview.chromium.org/2722783003
Cr-Commit-Position: refs/heads/master@{#468931}
Committed: https://chromium.googlesource.com/chromium/src/+/e43e4863433f22fa9316fadb57f965934a20881d

[vabr (Chromium), 2017-05-01 18:46:41]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:47:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-05-01 18:47:09]

Description was changed from

==========
[WIP] Separate deletion button in password settings

The "Delete this password" button gets a separate section. Before this CL it
shares the section with the password value (separate from username and site),
but the deletion affects the whole credential, so it should be separate.

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c40

TODO: Tests to be done.

BUG=159166
==========

to

==========
Separate deletion button in password settings

The "Delete this password" button gets a separate section. Before this CL it
shares the section with the password value (separate from username and site),
but the deletion affects the whole credential, so it should be separate.

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c40

BUG=159166
==========

[vabr (Chromium), 2017-05-01 18:50:52]

vabr@chromium.org changed reviewers:
+ lpromero@chromium.org

[vabr (Chromium), 2017-05-01 18:50:53]

Hi lpromero@,

This is CL 3/3 from the series. Please review at your leisure.

Cheers,
Vaclav

[commit-bot: I haz the power, 2017-05-01 19:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:47:37]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-05-02 16:32:56]

lgtm

[vabr (Chromium), 2017-05-03 08:43:53]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 08:44:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 08:47:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 08:47:32]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2017-05-03 09:29:41]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 09:29:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 09:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 09:41:54]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-05-03 10:32:02]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-05-03 10:32:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2722783003/#ps60001
(title: "Just rebased")

[commit-bot: I haz the power, 2017-05-03 10:32:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 10:35:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493807522604480,
"parent_rev": "b65a25e558ff3d3f3e411e3aa2fb09cab0fe2ca1", "commit_rev":
"e43e4863433f22fa9316fadb57f965934a20881d"}

[commit-bot: I haz the power, 2017-05-03 10:35:37]

Description was changed from

==========
Separate deletion button in password settings

The "Delete this password" button gets a separate section. Before this CL it
shares the section with the password value (separate from username and site),
but the deletion affects the whole credential, so it should be separate.

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c40

BUG=159166
==========

to

==========
Separate deletion button in password settings

The "Delete this password" button gets a separate section. Before this CL it
shares the section with the password value (separate from username and site),
but the deletion affects the whole credential, so it should be separate.

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c40

BUG=159166

Review-Url: https://codereview.chromium.org/2722783003
Cr-Commit-Position: refs/heads/master@{#468931}
Committed:
https://chromium.googlesource.com/chromium/src/+/e43e4863433f22fa9316fadb57f9...
==========

[commit-bot: I haz the power, 2017-05-03 10:35:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e43e4863433f22fa9316fadb57f9...