MD Settings: add an aria-label to control indicators (often policy)

MD Settings: add an aria-label to control indicators (often policy)

R=hcarmona@chromium.org
BUG=686327, 686309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2720413002
Cr-Commit-Position: refs/heads/master@{#455120}
Committed: https://chromium.googlesource.com/chromium/src/+/878954073e38da75b13a8d1299eb0e51e2440dab

[Dan Beam, 2017-03-01 00:37:59]

Description was changed from

==========
MD Settings: add an aria-label to control indicators (often policy)

R=hcarmona@chromium.org
BUG=686327,686309
==========

to

==========
MD Settings: add an aria-label to control indicators (often policy)

R=hcarmona@chromium.org
BUG=686327,686309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-01 00:41:49]

so, right now all the <iron-icon tabindex="0"> have an aria-describedby, but not
an aria-label nor aria-labelledby.

this basically results in both voiceover and chromevox reading "unknown" as the
label, THEN the description.

with just "This setting is disabled by your administrator", it's less than ideal
context, IMO (though I could potentially be convinced).

this ensures that if somebody's only use Tab and a screenreader, when hitting a
policy icon they're given a useful label

[Dan Beam, 2017-03-01 01:51:56]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 01:52:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 02:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 02:03:01]

Dry run: CQ cannot get SignCLA result. Please try later.

[hcarmona, 2017-03-01 19:17:34]

LGTM, just wondering if there are any screen readers that won't read the
description after the label

[Dan Beam, 2017-03-03 22:56:29]

On 2017/03/01 19:17:34, hcarmona wrote:
> LGTM, just wondering if there are any screen readers that won't read the
> description after the label

there are probably both screen readers that don't care about the description AND
verbosity settings in which description isn't read (even if the screen reader
understands them).

[stevenjb, 2017-03-06 18:31:58]

On 2017/03/03 22:56:29, Dan Beam wrote:
> On 2017/03/01 19:17:34, hcarmona wrote:
> > LGTM, just wondering if there are any screen readers that won't read the
> > description after the label
> 
> there are probably both screen readers that don't care about the description
AND
> verbosity settings in which description isn't read (even if the screen reader
> understands them).

Do we have a document explaining all of this and what we should be using? I'm
confused :)

[Dan Beam, 2017-03-06 19:09:54]

On 2017/03/06 18:31:58, stevenjb wrote:
> On 2017/03/03 22:56:29, Dan Beam wrote:
> > On 2017/03/01 19:17:34, hcarmona wrote:
> > > LGTM, just wondering if there are any screen readers that won't read the
> > > description after the label
> > 
> > there are probably both screen readers that don't care about the description
> AND
> > verbosity settings in which description isn't read (even if the screen
reader
> > understands them).
> 
> Do we have a document explaining all of this and what we should be using? I'm
> confused :)

yes, but it's a bit long https://www.w3.org/TR/wai-aria/roles#namecalculation

[Dan Beam, 2017-03-07 04:26:20]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-03-07 04:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2720413002/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-03-07 04:26:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:31:19]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2017-03-07 06:29:13]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-03-07 06:29:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org
Link to the patchset: https://codereview.chromium.org/2720413002/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-03-07 06:30:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:59:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Dan Beam, 2017-03-07 15:55:54]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-07 15:57:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 17:37:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488902154559180,
"parent_rev": "5910889b1aa6e3775eb7cb9539dc096e16050aa0", "commit_rev":
"ed602c2553ab9e2d3f9ba670358b8933850f3c93"}

[commit-bot: I haz the power, 2017-03-07 17:42:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488902154559180,
"parent_rev": "ec6b1258dc4f35bc2a885f646d899f9646872070", "commit_rev":
"878954073e38da75b13a8d1299eb0e51e2440dab"}

[commit-bot: I haz the power, 2017-03-07 17:44:49]

Description was changed from

==========
MD Settings: add an aria-label to control indicators (often policy)

R=hcarmona@chromium.org
BUG=686327,686309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: add an aria-label to control indicators (often policy)

R=hcarmona@chromium.org
BUG=686327,686309
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2720413002
Cr-Commit-Position: refs/heads/master@{#455120}
Committed:
https://chromium.googlesource.com/chromium/src/+/878954073e38da75b13a8d1299eb...
==========

[commit-bot: I haz the power, 2017-03-07 17:44:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/878954073e38da75b13a8d1299eb...