Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy) (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 1 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
2 <link rel="import" href="chrome://resources/html/md_select_css.html"> 2 <link rel="import" href="chrome://resources/html/md_select_css.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
8 <link rel="import" href="appearance_browser_proxy.html"> 8 <link rel="import" href="appearance_browser_proxy.html">
9 <link rel="import" href="../controls/controlled_radio_button.html"> 9 <link rel="import" href="../controls/controlled_radio_button.html">
10 <link rel="import" href="../controls/extension_controlled_indicator.html"> 10 <link rel="import" href="../controls/extension_controlled_indicator.html">
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 sub-label="[[getShowHomeSubLabel_( 98 sub-label="[[getShowHomeSubLabel_(
99 prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]"> 99 prefs.homepage_is_newtabpage.value, prefs.homepage.value)]]">
100 </settings-toggle-button> 100 </settings-toggle-button>
101 </div> 101 </div>
102 <template is="dom-if" if="[[prefs.browser.show_home_button.value]]"> 102 <template is="dom-if" if="[[prefs.browser.show_home_button.value]]">
103 <div class="list-frame" 103 <div class="list-frame"
104 hidden="[[!pageVisibility.homeButton]]"> 104 hidden="[[!pageVisibility.homeButton]]">
105 <settings-radio-group pref="{{prefs.homepage_is_newtabpage}}"> 105 <settings-radio-group pref="{{prefs.homepage_is_newtabpage}}">
106 <controlled-radio-button class="list-item" name="true" 106 <controlled-radio-button class="list-item" name="true"
107 pref="[[prefs.homepage_is_newtabpage]]" 107 pref="[[prefs.homepage_is_newtabpage]]"
108 no-extension-indicator> 108 label="$i18n{homePageNtp}" no-extension-indicator>
109 $i18n{homePageNtp}
110 </controlled-radio-button> 109 </controlled-radio-button>
111 <controlled-radio-button class="list-item" name="false" 110 <controlled-radio-button class="list-item" name="false"
112 pref="[[prefs.homepage_is_newtabpage]]" 111 pref="[[prefs.homepage_is_newtabpage]]" label="$i18n{other}"
113 no-extension-indicator> 112 no-extension-indicator>
114 $i18n{other}
115 <!-- TODO(dbeam): this can show double indicators when both 113 <!-- TODO(dbeam): this can show double indicators when both
116 homepage and whether to use the NTP as the homepage are 114 homepage and whether to use the NTP as the homepage are
117 managed. --> 115 managed. -->
118 <settings-input no-label-float pref="{{prefs.homepage}}" 116 <settings-input no-label-float pref="{{prefs.homepage}}"
119 label="$i18n{exampleDotCom}" 117 label="$i18n{exampleDotCom}"
120 can-tab="[[!prefs.homepage_is_newtabpage.value]]" 118 can-tab="[[!prefs.homepage_is_newtabpage.value]]"
121 stop-keyboard-event-propagation no-extension-indicator> 119 stop-keyboard-event-propagation no-extension-indicator>
122 </settings-input> 120 </settings-input>
123 </controlled-radio-button> 121 </controlled-radio-button>
124 <template is="dom-if" if="[[prefs.homepage.extensionId]]"> 122 <template is="dom-if" if="[[prefs.homepage.extensionId]]">
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 associated-control="[[$$('#customize-fonts-subpage-trigger')]]" 186 associated-control="[[$$('#customize-fonts-subpage-trigger')]]"
189 page-title="$i18n{customizeFonts}"> 187 page-title="$i18n{customizeFonts}">
190 <settings-appearance-fonts-page prefs="{{prefs}}"> 188 <settings-appearance-fonts-page prefs="{{prefs}}">
191 </settings-appearance-fonts-page> 189 </settings-appearance-fonts-page>
192 </settings-subpage> 190 </settings-subpage>
193 </template> 191 </template>
194 </settings-animated-pages> 192 </settings-animated-pages>
195 </template> 193 </template>
196 <script src="appearance_page.js"></script> 194 <script src="appearance_page.js"></script>
197 </dom-module> 195 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698