chrome/browser/resources/settings/controls/controlled_radio_button.html - Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/controls/controlled_radio_button.html

Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy) (Closed)

Patch Set: merge Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/controlled_button.js ('k') | chrome/browser/resources/settings/controls/controlled_radio_button.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html">

3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">	3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">

4 <link rel="import" href="pref_control_behavior.html">	4 <link rel="import" href="pref_control_behavior.html">

5 <link rel="import" href="../prefs/pref_util.html">	5 <link rel="import" href="../prefs/pref_util.html">

6 <link rel="import" href="../settings_shared_css.html">	6 <link rel="import" href="../settings_shared_css.html">

7	7

8 <dom-module id="controlled-radio-button">	8 <dom-module id="controlled-radio-button">

9 <template>	9 <template>

10 <style include="settings-shared">	10 <style include="settings-shared">

(...skipping 16 matching lines...) Expand all Loading...
27 cr-policy-pref-indicator {	27 cr-policy-pref-indicator {

28 -webkit-margin-start: var(--checkbox-spacing);	28 -webkit-margin-start: var(--checkbox-spacing);

29 /* Enable pointer events for the indicator so :hover works. Disable	29 /* Enable pointer events for the indicator so :hover works. Disable

30 * clicks/taps via onIndicatorTap_ so outer on-tap doesn't trigger. */	30 * clicks/taps via onIndicatorTap_ so outer on-tap doesn't trigger. */

31 pointer-events: all;	31 pointer-events: all;

32 }	32 }

33 </style>	33 </style>

34	34

35 <paper-radio-button id="radioButton" name="{{name}}" checked="{{checked}}"	35 <paper-radio-button id="radioButton" name="{{name}}" checked="{{checked}}"

36 disabled="[[controlled_]]" tabindex$="[[tabindex]]">	36 disabled="[[controlled_]]" tabindex$="[[tabindex]]">

37 <content></content>	37 [[label]] <content></content>

38 </paper-radio-button>	38 </paper-radio-button>

39	39

40 <template is="dom-if" if="[[showIndicator_(controlled_, name, pref.*)]]">	40 <template is="dom-if" if="[[showIndicator_(controlled_, name, pref.*)]]">

41 <cr-policy-pref-indicator pref="[[pref]]" on-tap="onIndicatorTap_">	41 <cr-policy-pref-indicator pref="[[pref]]" on-tap="onIndicatorTap_"

	42 icon-aria-label="[[label]]">

42 </cr-policy-pref-indicator>	43 </cr-policy-pref-indicator>

43 </template>	44 </template>

44	45

45 </template>	46 </template>

46 <script src="controlled_radio_button.js"></script>	47 <script src="controlled_radio_button.js"></script>

47 </dom-module>	48 </dom-module>

OLD	NEW