chrome/browser/resources/settings/controls/settings_toggle_button.html - Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.html

Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy) (Closed)

Patch Set: merge Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/settings_input.html ('k') | chrome/browser/resources/settings/date_time_page/date_time_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_toggle_button.html

diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.html b/chrome/browser/resources/settings/controls/settings_toggle_button.html

index 22e2bb5e9b0386f73a20320a374f51aa48186e6d..1b50447ca8f041dd9d6374137dc2ce176aa509c7 100644

--- a/chrome/browser/resources/settings/controls/settings_toggle_button.html

+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.html

@@ -40,14 +40,13 @@

<div class="flex" on-tap="onLabelWrapperTap_"

actionable$="[[!controlDisabled_(disabled, pref.*)]]">

- <div id="label" class="label">

- [[label]]

- </div>

+ <div id="label" class="label">[[label]]</div>

<div class="secondary label">[[subLabel]]</div>

</div>

- <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>

+ <cr-policy-pref-indicator pref="[[pref]]" icon-aria-label="[[label]]">

+ </cr-policy-pref-indicator>

</template>

<paper-toggle-button id="control" checked="{{checked}}"

on-change="notifyChangedByUserInteraction" aria-labelledby="label"