chrome/browser/resources/settings/controls/settings_checkbox.html - Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/controls/settings_checkbox.html

Issue 2720413002: MD Settings: add an aria-label to control indicators (often policy) (Closed)

Patch Set: merge Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/controlled_radio_button.js ('k') | chrome/browser/resources/settings/controls/settings_input.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">	1 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_pref_in dicator.html">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">

4 <link rel="import" href="settings_boolean_control_behavior.html">	4 <link rel="import" href="settings_boolean_control_behavior.html">

5 <link rel="import" href="../settings_shared_css.html">	5 <link rel="import" href="../settings_shared_css.html">

6	6

7 <dom-module id="settings-checkbox">	7 <dom-module id="settings-checkbox">

8 <template>	8 <template>

9 <style include="settings-shared">	9 <style include="settings-shared">

10 #outerRow {	10 #outerRow {

(...skipping 20 matching lines...) Expand all Loading...
31 }	31 }

32 </style>	32 </style>

33 <div id="outerRow" noSubLabel$="[[!subLabel]]">	33 <div id="outerRow" noSubLabel$="[[!subLabel]]">

34 <paper-checkbox id="checkbox" checked="{{checked}}"	34 <paper-checkbox id="checkbox" checked="{{checked}}"

35 on-change="notifyChangedByUserInteraction"	35 on-change="notifyChangedByUserInteraction"

36 disabled="[[controlDisabled_(disabled, pref.*)]]">	36 disabled="[[controlDisabled_(disabled, pref.*)]]">

37 <div>[[label]] <content></content></div>	37 <div>[[label]] <content></content></div>

38 <div class="secondary">[[subLabel]]</div>	38 <div class="secondary">[[subLabel]]</div>

39 </paper-checkbox>	39 </paper-checkbox>

40 <template is="dom-if" if="[[pref.controlledBy]]">	40 <template is="dom-if" if="[[pref.controlledBy]]">

41 <cr-policy-pref-indicator pref="[[pref]]"></cr-policy-pref-indicator>	41 <cr-policy-pref-indicator pref="[[pref]]" icon-aria-label="[[label]]">

	42 </cr-policy-pref-indicator>

42 </template>	43 </template>

43 </div>	44 </div>

44 </template>	45 </template>

45 <script src="settings_checkbox.js"></script>	46 <script src="settings_checkbox.js"></script>

46 </dom-module>	47 </dom-module>

OLD	NEW