Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2719813002: Rename classes that derived from EmptyLocalFrameClient. (Closed)

Created:
3 years, 9 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, nessy, Srirama, szager+layoutwatch_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename classes that derived from EmptyLocalFrameClient. Renamed classes include: * MockFrameLoaderClient -> MockLocalFrameClient * FrameLoaderClientWithParent -> LocalFrameClientWithParent * SingleChildFrameLoaderClient -> SingleChildLocalFrameClient * StubFrameLoaderClient -> StubLocalFrameClient *** This is a rename change only - There are no logic changes. *** BUG=694773 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2719813002 Cr-Commit-Position: refs/heads/master@{#453154} Committed: https://chromium.googlesource.com/chromium/src/+/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -54 lines) Patch
M third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainterTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
slangley
3 years, 9 months ago (2017-02-27 01:10:00 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-27 01:14:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719813002/1
3 years, 9 months ago (2017-02-27 03:59:26 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 05:10:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3188f925b5c11711a53b2dd31e55...

Powered by Google App Engine
This is Rietveld 408576698