Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp

Issue 2719813002: Rename classes that derived from EmptyLocalFrameClient. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ElementVisibilityObserver.h" 5 #include "core/dom/ElementVisibilityObserver.h"
6 6
7 #include "core/dom/DOMImplementation.h" 7 #include "core/dom/DOMImplementation.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/RemoteFrame.h" 9 #include "core/frame/RemoteFrame.h"
10 #include "core/html/HTMLDivElement.h" 10 #include "core/html/HTMLDivElement.h"
11 #include "core/html/HTMLDocument.h" 11 #include "core/html/HTMLDocument.h"
12 #include "core/loader/EmptyClients.h" 12 #include "core/loader/EmptyClients.h"
13 #include "core/testing/DummyPageHolder.h" 13 #include "core/testing/DummyPageHolder.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace blink { 16 namespace blink {
17 17
18 namespace { 18 namespace {
19 19
20 // Stub implementation of FrameLoaderClient for the purpose of testing. It will 20 // Stub implementation of FrameLoaderClient for the purpose of testing. It will
21 // alow callers to set the parent/top frames by calling |setParent|. It is used 21 // alow callers to set the parent/top frames by calling |setParent|. It is used
22 // in ElementVisibilityObserverTest in order to mock a RemoteFrame parent of a 22 // in ElementVisibilityObserverTest in order to mock a RemoteFrame parent of a
23 // LocalFrame. 23 // LocalFrame.
24 class StubFrameLoaderClient final : public EmptyLocalFrameClient { 24 class StubLocalFrameClient final : public EmptyLocalFrameClient {
25 public: 25 public:
26 Frame* parent() const override { return m_parent; } 26 Frame* parent() const override { return m_parent; }
27 Frame* top() const override { return m_parent; } 27 Frame* top() const override { return m_parent; }
28 28
29 void setParent(Frame* frame) { m_parent = frame; } 29 void setParent(Frame* frame) { m_parent = frame; }
30 30
31 DEFINE_INLINE_VIRTUAL_TRACE() { 31 DEFINE_INLINE_VIRTUAL_TRACE() {
32 visitor->trace(m_parent); 32 visitor->trace(m_parent);
33 EmptyLocalFrameClient::trace(visitor); 33 EmptyLocalFrameClient::trace(visitor);
34 } 34 }
35 35
36 private: 36 private:
37 WeakMember<Frame> m_parent = nullptr; 37 WeakMember<Frame> m_parent = nullptr;
38 }; 38 };
39 39
40 class ElementVisibilityObserverTest : public ::testing::Test { 40 class ElementVisibilityObserverTest : public ::testing::Test {
41 protected: 41 protected:
42 void SetUp() override { 42 void SetUp() override {
43 m_frameLoaderClient = new StubFrameLoaderClient(); 43 m_localFrameClient = new StubLocalFrameClient();
44 m_dummyPageHolder = DummyPageHolder::create( 44 m_dummyPageHolder = DummyPageHolder::create(
45 IntSize(), nullptr, m_frameLoaderClient, nullptr, nullptr); 45 IntSize(), nullptr, m_localFrameClient, nullptr, nullptr);
46 } 46 }
47 47
48 void TearDown() override { 48 void TearDown() override {
49 m_dummyPageHolder->frame().detach(FrameDetachType::Remove); 49 m_dummyPageHolder->frame().detach(FrameDetachType::Remove);
50 } 50 }
51 51
52 Document& document() { return m_dummyPageHolder->document(); } 52 Document& document() { return m_dummyPageHolder->document(); }
53 FrameHost& frameHost() { return m_dummyPageHolder->page().frameHost(); } 53 FrameHost& frameHost() { return m_dummyPageHolder->page().frameHost(); }
54 StubFrameLoaderClient* frameLoaderClient() const { 54 StubLocalFrameClient* localFrameClient() const { return m_localFrameClient; }
55 return m_frameLoaderClient;
56 }
57 55
58 private: 56 private:
59 std::unique_ptr<DummyPageHolder> m_dummyPageHolder; 57 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
60 Persistent<StubFrameLoaderClient> m_frameLoaderClient; 58 Persistent<StubLocalFrameClient> m_localFrameClient;
61 }; 59 };
62 60
63 TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) { 61 TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) {
64 HTMLElement* element = HTMLDivElement::create( 62 HTMLElement* element = HTMLDivElement::create(
65 *DOMImplementation::create(document())->createHTMLDocument("test")); 63 *DOMImplementation::create(document())->createHTMLDocument("test"));
66 ElementVisibilityObserver* observer = 64 ElementVisibilityObserver* observer =
67 new ElementVisibilityObserver(element, nullptr); 65 new ElementVisibilityObserver(element, nullptr);
68 observer->start(); 66 observer->start();
69 observer->stop(); 67 observer->stop();
70 // It should not crash. 68 // It should not crash.
71 } 69 }
72 70
73 TEST_F(ElementVisibilityObserverTest, ObserveElementInRemoteFrame) { 71 TEST_F(ElementVisibilityObserverTest, ObserveElementInRemoteFrame) {
74 Persistent<RemoteFrame> remoteFrame = 72 Persistent<RemoteFrame> remoteFrame =
75 RemoteFrame::create(new EmptyRemoteFrameClient(), &frameHost(), nullptr); 73 RemoteFrame::create(new EmptyRemoteFrameClient(), &frameHost(), nullptr);
76 frameLoaderClient()->setParent(remoteFrame); 74 localFrameClient()->setParent(remoteFrame);
77 75
78 Persistent<HTMLElement> element = HTMLDivElement::create(document()); 76 Persistent<HTMLElement> element = HTMLDivElement::create(document());
79 ElementVisibilityObserver* observer = 77 ElementVisibilityObserver* observer =
80 new ElementVisibilityObserver(element, WTF::bind([](bool) {})); 78 new ElementVisibilityObserver(element, WTF::bind([](bool) {}));
81 observer->start(); 79 observer->start();
82 observer->deliverObservationsForTesting(); 80 observer->deliverObservationsForTesting();
83 observer->stop(); 81 observer->stop();
84 // It should not crash. 82 // It should not crash.
85 } 83 }
86 84
87 } // anonymous namespace 85 } // anonymous namespace
88 86
89 } // blink namespace 87 } // blink namespace
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698