Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2712343003: Rename FrameLoaderClient* to LocalFrameClient* in web/ (Closed)

Created:
3 years, 9 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, sashab
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename FrameLoaderClient* to LocalFrameClient* in web/ Remove no longer referenced FrameLoaderClientImpl.h *** This is a rename cl only - there are no logic changes *** BUG=694773 Review-Url: https://codereview.chromium.org/2712343003 Cr-Commit-Position: refs/heads/master@{#453164} Committed: https://chromium.googlesource.com/chromium/src/+/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -70 lines) Patch
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHelperPluginImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 4 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
slangley
3 years, 9 months ago (2017-02-27 01:46:24 UTC) #2
sashab
Add newline between title and desc in CL description LGTM
3 years, 9 months ago (2017-02-27 01:48:39 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-02-27 01:55:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712343003/1
3 years, 9 months ago (2017-02-27 05:21:24 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 07:10:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a2e69bfc0c4c828211ec6b0ece0...

Powered by Google App Engine
This is Rietveld 408576698