Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp

Issue 2719813002: Rename classes that derived from EmptyLocalFrameClient. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp b/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
index b0822863abf03983619138896e9ad26c5f9d842e..efff024f94f6d835cb4bc29f4cbd64b1c50855ad 100644
--- a/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
+++ b/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
@@ -21,7 +21,7 @@ namespace {
// alow callers to set the parent/top frames by calling |setParent|. It is used
// in ElementVisibilityObserverTest in order to mock a RemoteFrame parent of a
// LocalFrame.
-class StubFrameLoaderClient final : public EmptyLocalFrameClient {
+class StubLocalFrameClient final : public EmptyLocalFrameClient {
public:
Frame* parent() const override { return m_parent; }
Frame* top() const override { return m_parent; }
@@ -40,9 +40,9 @@ class StubFrameLoaderClient final : public EmptyLocalFrameClient {
class ElementVisibilityObserverTest : public ::testing::Test {
protected:
void SetUp() override {
- m_frameLoaderClient = new StubFrameLoaderClient();
+ m_localFrameClient = new StubLocalFrameClient();
m_dummyPageHolder = DummyPageHolder::create(
- IntSize(), nullptr, m_frameLoaderClient, nullptr, nullptr);
+ IntSize(), nullptr, m_localFrameClient, nullptr, nullptr);
}
void TearDown() override {
@@ -51,13 +51,11 @@ class ElementVisibilityObserverTest : public ::testing::Test {
Document& document() { return m_dummyPageHolder->document(); }
FrameHost& frameHost() { return m_dummyPageHolder->page().frameHost(); }
- StubFrameLoaderClient* frameLoaderClient() const {
- return m_frameLoaderClient;
- }
+ StubLocalFrameClient* localFrameClient() const { return m_localFrameClient; }
private:
std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
- Persistent<StubFrameLoaderClient> m_frameLoaderClient;
+ Persistent<StubLocalFrameClient> m_localFrameClient;
};
TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) {
@@ -73,7 +71,7 @@ TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) {
TEST_F(ElementVisibilityObserverTest, ObserveElementInRemoteFrame) {
Persistent<RemoteFrame> remoteFrame =
RemoteFrame::create(new EmptyRemoteFrameClient(), &frameHost(), nullptr);
- frameLoaderClient()->setParent(remoteFrame);
+ localFrameClient()->setParent(remoteFrame);
Persistent<HTMLElement> element = HTMLDivElement::create(document());
ElementVisibilityObserver* observer =
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698