Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2721503002: Rename all uses of EmptyFrameLoaderClient with EmptyLocalFrameClient. (Closed)

Created:
3 years, 9 months ago by slangley
Modified:
3 years, 9 months ago
Reviewers:
haraken, sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, fs, gasubic, gyuyoung2, haraken, hongchan, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Raymond Toy, Stephen Chennney, sof, nessy, Srirama, szager+layoutwatch_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename all uses of EmptyFrameLoaderClient with EmptyLocalFrameClient. In some places, the definition was being included transitively so also added the header file for LocalFrameClient. This is part of a larger effort to rename FrameLoaderClient to LocalFrameClient. *** This is a rename only change - there are no logic changes *** BUG=694773 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2721503002 Cr-Commit-Position: refs/heads/master@{#453142} Committed: https://chromium.googlesource.com/chromium/src/+/983682ac5f1fc3332506eb3969c23b4f8301185a

Patch Set 1 #

Patch Set 2 : Change V8 headers to user includes and introduce a space between system and user headers. Headers w… #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -68 lines) Patch
M third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 1 6 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 4 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 4 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTrackerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FrameTree.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 5 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2721473003 Patch 1

Dependent Patchsets:

Issue 2719813002 Patch 1

Messages

Total messages: 11 (6 generated)
slangley
3 years, 9 months ago (2017-02-27 00:19:01 UTC) #3
slangley
3 years, 9 months ago (2017-02-27 00:21:40 UTC) #4
haraken
LGTM https://codereview.chromium.org/2721503002/diff/20001/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp File third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp (right): https://codereview.chromium.org/2721503002/diff/20001/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp#newcode85 third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp:85: class StubFrameLoaderClient : public EmptyLocalFrameClient { Consider renaming ...
3 years, 9 months ago (2017-02-27 00:23:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721503002/20001
3 years, 9 months ago (2017-02-27 02:01:51 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 03:54:50 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/983682ac5f1fc3332506eb3969c2...

Powered by Google App Engine
This is Rietveld 408576698