[Mac] Make bubble arrow location/position RTL-aware

[Mac] Make bubble arrow location/position RTL-aware

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG=678257
Review-Url: https://codereview.chromium.org/2717603003
Cr-Commit-Position: refs/heads/master@{#453232}
Committed: https://chromium.googlesource.com/chromium/src/+/0d2ad84ffb7dfb632cbfe9f847daa931ae128344

[lgrey, 2017-02-23 22:45:39]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:46:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:13:39]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-02-24 15:23:30]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org

[lgrey, 2017-02-24 15:23:30]

PTAL :)

[Elly Fong-Jones, 2017-02-24 15:34:31]

lgtm :D

note that I am not a c/b/ui/cocoa OWNER so you'll need someone else too.

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/info_bubble_view.h (right):

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/info_bubble_view.h:32: }
remove newline?

[lgrey, 2017-02-24 15:38:39]

lgrey@chromium.org changed reviewers:
+ thakis@chromium.org

[lgrey, 2017-02-24 15:38:39]

Thanks, Elly!

Nico PTAL for OWNERS :)

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/info_bubble_view.h (right):

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/info_bubble_view.h:32: }
On 2017/02/24 15:34:31, Elly Fong-Jones wrote:
> remove newline?

CL format made me do this! Will kill two birds with one stone by adding Nico for
OWNERS. Nico do you know what's up with this?

[Nico, 2017-02-24 15:46:43]

Elly, want to send me a CL to add yourself to chrome/browser/ui/cocoa/OWNERS?

[Nico, 2017-02-24 15:52:09]

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/info_bubble_view.h (right):

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/info_bubble_view.h:32: }
On 2017/02/24 15:38:39, lgrey wrote:
> On 2017/02/24 15:34:31, Elly Fong-Jones wrote:
> > remove newline?
> 
> CL format made me do this! Will kill two birds with one stone by adding Nico
for
> OWNERS. Nico do you know what's up with this?

That looks pretty bad :-( filed
https://bugs.chromium.org/p/chromium/issues/detail?id=695885 , will investigate
today

[lgrey, 2017-02-27 15:56:25]

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/info_bubble_view.h (right):

https://codereview.chromium.org/2717603003/diff/1/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/info_bubble_view.h:32: }
On 2017/02/24 15:52:09, Nico wrote:
> On 2017/02/24 15:38:39, lgrey wrote:
> > On 2017/02/24 15:34:31, Elly Fong-Jones wrote:
> > > remove newline?
> > 
> > CL format made me do this! Will kill two birds with one stone by adding Nico
> for
> > OWNERS. Nico do you know what's up with this?
> 
> That looks pretty bad :-( filed
> https://bugs.chromium.org/p/chromium/issues/detail?id=695885 , will
investigate
> today

Thanks for the clang-format fix, done.

[lgrey, 2017-02-27 15:56:32]

The CQ bit was checked by lgrey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:56:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-27 15:57:20]

(clang-format roll got reverted, this is still broken.)

On Mon, Feb 27, 2017 at 10:56 AM, <lgrey@chromium.org> wrote:

>
> https://codereview.chromium.org/2717603003/diff/1/chrome/
> browser/ui/cocoa/info_bubble_view.h
> File chrome/browser/ui/cocoa/info_bubble_view.h (right):
>
> https://codereview.chromium.org/2717603003/diff/1/chrome/
> browser/ui/cocoa/info_bubble_view.h#newcode32
> chrome/browser/ui/cocoa/info_bubble_view.h:32: }
> On 2017/02/24 15:52:09, Nico wrote:
> > On 2017/02/24 15:38:39, lgrey wrote:
> > > On 2017/02/24 15:34:31, Elly Fong-Jones wrote:
> > > > remove newline?
> > >
> > > CL format made me do this! Will kill two birds with one stone by
> adding Nico
> > for
> > > OWNERS. Nico do you know what's up with this?
> >
> > That looks pretty bad :-( filed
> > https://bugs.chromium.org/p/chromium/issues/detail?id=695885 , will
> investigate
> > today
>
> Thanks for the clang-format fix, done.
>
> https://codereview.chromium.org/2717603003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[lgrey, 2017-02-27 15:59:49]

Odd, it let me upload!

[commit-bot: I haz the power, 2017-02-27 16:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:18:35]

Dry run: This issue passed the CQ dry run.

[lgrey, 2017-02-27 16:22:30]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-02-27 16:22:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2717603003/#ps20001
(title: "Now with proper enum formatting")

[commit-bot: I haz the power, 2017-02-27 16:22:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:27:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488212550127630,
"parent_rev": "1af02e1b955033e1cd88915dadb0c7100d6bb40a", "commit_rev":
"0d2ad84ffb7dfb632cbfe9f847daa931ae128344"}

[commit-bot: I haz the power, 2017-02-27 16:27:41]

Description was changed from

==========
[Mac] Make bubble arrow location/position RTL-aware

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG=678257
==========

to

==========
[Mac] Make bubble arrow location/position RTL-aware

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG=678257

Review-Url: https://codereview.chromium.org/2717603003
Cr-Commit-Position: refs/heads/master@{#453232}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d2ad84ffb7dfb632cbfe9f847da...
==========

[commit-bot: I haz the power, 2017-02-27 16:27:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d2ad84ffb7dfb632cbfe9f847da...