Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5877)

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)
Patch Set: Now with proper enum formatting Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
index 05466b1b4f64767c872604c411a14dd17ac04cb8..c7cc3b1e3af0c44e04708ea146232991b65016da 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
@@ -165,7 +165,7 @@ class BaseBubbleControllerTest : public CocoaTest {
// Test that kAlignEdgeToAnchorEdge and a left bubble arrow correctly aligns the
// left edge of the buble to the anchor point.
TEST_F(BaseBubbleControllerTest, LeftAlign) {
- [[controller_ bubble] setArrowLocation:info_bubble::kTopLeft];
+ [[controller_ bubble] setArrowLocation:info_bubble::kTopLeading];
[[controller_ bubble] setAlignment:info_bubble::kAlignEdgeToAnchorEdge];
[controller_ showWindow:nil];
@@ -181,7 +181,7 @@ TEST_F(BaseBubbleControllerTest, LeftAlign) {
// Test that kAlignEdgeToAnchorEdge and a right bubble arrow correctly aligns
// the right edge of the buble to the anchor point.
TEST_F(BaseBubbleControllerTest, RightAlign) {
- [[controller_ bubble] setArrowLocation:info_bubble::kTopRight];
+ [[controller_ bubble] setArrowLocation:info_bubble::kTopTrailing];
[[controller_ bubble] setAlignment:info_bubble::kAlignEdgeToAnchorEdge];
[controller_ showWindow:nil];
@@ -197,7 +197,7 @@ TEST_F(BaseBubbleControllerTest, RightAlign) {
// Test that kAlignArrowToAnchor and a left bubble arrow correctly aligns
// the bubble arrow to the anchor point.
TEST_F(BaseBubbleControllerTest, AnchorAlignLeftArrow) {
- [[controller_ bubble] setArrowLocation:info_bubble::kTopLeft];
+ [[controller_ bubble] setArrowLocation:info_bubble::kTopLeading];
[[controller_ bubble] setAlignment:info_bubble::kAlignArrowToAnchor];
[controller_ showWindow:nil];
@@ -214,7 +214,7 @@ TEST_F(BaseBubbleControllerTest, AnchorAlignLeftArrow) {
// Test that kAlignArrowToAnchor and a right bubble arrow correctly aligns
// the bubble arrow to the anchor point.
TEST_F(BaseBubbleControllerTest, AnchorAlignRightArrow) {
- [[controller_ bubble] setArrowLocation:info_bubble::kTopRight];
+ [[controller_ bubble] setArrowLocation:info_bubble::kTopTrailing];
[[controller_ bubble] setAlignment:info_bubble::kAlignArrowToAnchor];
[controller_ showWindow:nil];
@@ -248,7 +248,7 @@ TEST_F(BaseBubbleControllerTest, AnchorAlignCenterArrow) {
// ensures offscreen initialization is done using correct screen metrics.
TEST_F(BaseBubbleControllerTest, PositionedBeforeShow) {
// Verify default alignment settings, used when initialized in SetUp().
- EXPECT_EQ(info_bubble::kTopRight, [[controller_ bubble] arrowLocation]);
+ EXPECT_EQ(info_bubble::kTopTrailing, [[controller_ bubble] arrowLocation]);
EXPECT_EQ(info_bubble::kAlignArrowToAnchor, [[controller_ bubble] alignment]);
// Verify the default frame (positioned relative to the test_window() origin).
« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698