[Mac] Make bubble arrow location/position RTL-aware

chrome/browser/ui/cocoa/info_bubble_view.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
+#import "chrome/browser/ui/cocoa/l10n_util.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSBezierPath+RoundRect.h"
 
 @implementation InfoBubbleView
 
 @synthesize arrowLocation = arrowLocation_;
 @synthesize alignment = alignment_;
 @synthesize cornerFlags = cornerFlags_;
 
 - (id)initWithFrame:(NSRect)frameRect {
   if ((self = [super initWithFrame:frameRect])) {
-    arrowLocation_ = info_bubble::kTopLeft;
+    arrowLocation_ = info_bubble::kTopLeading;
     alignment_ = info_bubble::kAlignArrowToAnchor;
     cornerFlags_ = info_bubble::kRoundedAllCorners;
     backgroundColor_.reset([[NSColor whiteColor] retain]);
   }
   return self;
 }
 
 - (BOOL)performKeyEquivalent:(NSEvent *)event {
   InfoBubbleWindow* info_bubble_window =
       base::mac::ObjCCast<InfoBubbleWindow>([self window]);
@@ skipping 26 matching lines @@
       info_bubble::kBubbleCornerRadius : 0;
 
   NSBezierPath* bezier =
       [NSBezierPath gtm_bezierPathWithRoundRect:bounds
                             topLeftCornerRadius:topRadius
                            topRightCornerRadius:topRadius
                          bottomLeftCornerRadius:bottomRadius
                         bottomRightCornerRadius:bottomRadius];
 
   // Add the bubble arrow.
+  BOOL isRTL = cocoa_l10n_util::ShouldDoExperimentalRTLLayout();
   CGFloat dX = 0;
+  CGFloat leftOffset = info_bubble::kBubbleArrowXOffset;
+  CGFloat rightOffset = NSWidth(bounds) - info_bubble::kBubbleArrowXOffset -
+                        info_bubble::kBubbleArrowWidth;
   switch (arrowLocation_) {
-    case info_bubble::kTopLeft:
-      dX = info_bubble::kBubbleArrowXOffset;
+    case info_bubble::kTopLeading:
+      dX = isRTL ? rightOffset : leftOffset;
       break;
-    case info_bubble::kTopRight:
-      dX = NSWidth(bounds) - info_bubble::kBubbleArrowXOffset -
-          info_bubble::kBubbleArrowWidth;
+    case info_bubble::kTopTrailing:
+      dX = isRTL ? leftOffset : rightOffset;
       break;
     case info_bubble::kTopCenter:
       dX = NSMidX(bounds) - info_bubble::kBubbleArrowWidth / 2.0;
       break;
     case info_bubble::kNoArrow:
       break;
     default:
       NOTREACHED();
       break;
   }
@@ skipping 11 matching lines @@
   [bezier closePath];
   [backgroundColor_ set];
   [bezier fill];
 }
 
 - (NSPoint)arrowTip {
   NSRect bounds = [self bounds];
   CGFloat tipXOffset =
       info_bubble::kBubbleArrowXOffset + info_bubble::kBubbleArrowWidth / 2.0;
   CGFloat xOffset = 0.0;
+  BOOL isRTL = cocoa_l10n_util::ShouldDoExperimentalRTLLayout();
+  CGFloat leftOffset = NSMaxX(bounds) - tipXOffset;
+  CGFloat rightOffset = NSMinX(bounds) + tipXOffset;
   switch(arrowLocation_) {
-    case info_bubble::kTopRight:
-      xOffset = NSMaxX(bounds) - tipXOffset;
+    case info_bubble::kTopTrailing:
+      xOffset = isRTL ? rightOffset : leftOffset;
       break;
-    case info_bubble::kTopLeft:
-      xOffset = NSMinX(bounds) + tipXOffset;
+    case info_bubble::kTopLeading:
+      xOffset = isRTL ? leftOffset : rightOffset;
       break;
     case info_bubble::kTopCenter:
       xOffset = NSMidX(bounds);
       break;
     default:
       NOTREACHED();
       break;
   }
   NSPoint arrowTip = NSMakePoint(xOffset, NSMaxY(bounds));
   return arrowTip;
 }
 
 - (NSColor*)backgroundColor {
   return backgroundColor_;
 }
 
 - (void)setBackgroundColor:(NSColor*)backgroundColor {
   backgroundColor_.reset([backgroundColor retain]);
 }
 
 - (void)setArrowLocation:(info_bubble::BubbleArrowLocation)location {
   if (arrowLocation_ == location)
     return;
 
   arrowLocation_ = location;
   [self setNeedsDisplayInRect:[self bounds]];
 }
 
 @end