[Mac] Make bubble arrow location/position RTL-aware

chrome/browser/ui/cocoa/info_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_INFO_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_COCOA_INFO_BUBBLE_VIEW_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
 
 namespace info_bubble {
 
 // These values are in view coordinates.
 const CGFloat kBubbleArrowHeight = 8.0;
 const CGFloat kBubbleArrowWidth = 15.0;
 const CGFloat kBubbleCornerRadius = 2.0;
 const CGFloat kBubbleArrowXOffset = kBubbleArrowWidth + kBubbleCornerRadius;
 
 // Constants that define where the bubble will have rounded corners.
 enum CornerFlags {
   kRoundedTopCorners = 1,
   kRoundedBottomCorners = 1 << 1,
   kRoundedAllCorners = kRoundedTopCorners | kRoundedBottomCorners,
 };
 
 enum BubbleArrowLocation {
-  kTopLeft,
+  kTopLeading,
   kTopCenter,
-  kTopRight,
+  kTopTrailing,
   kNoArrow,
-};
+}

[Elly Fong-Jones, 2017/02/24 15:34:31]

remove newline?

[lgrey, 2017/02/24 15:38:39]

CL format made me do this! Will kill two birds with one stone by adding Nico for
OWNERS. Nico do you know what's up with this?

[Nico, 2017/02/24 15:52:09]

That looks pretty bad :-( filed
https://bugs.chromium.org/p/chromium/issues/detail?id=695885 , will investigate
today

[lgrey, 2017/02/27 15:56:25]

Thanks for the clang-format fix, done.

+;
 
 enum BubbleAlignment {
   // The tip of the arrow points to the anchor point.
   kAlignArrowToAnchor,
   // The edge nearest to the arrow is lined up with the anchor point.
   kAlignEdgeToAnchorEdge,
   // Align the trailing edge (right in LTR, left in RTL) to the anchor point.
   kAlignTrailingEdgeToAnchorEdge,
   // Align the leading edge (left in LTR, right in RTL)  to the anchor point.
   kAlignLeadingEdgeToAnchorEdge,
@@ skipping 18 matching lines @@
 // Returns the point location in view coordinates of the tip of the arrow.
 - (NSPoint)arrowTip;
 
 // Gets and sets the bubble's background color.
 - (NSColor*)backgroundColor;
 - (void)setBackgroundColor:(NSColor*)backgroundColor;
 
 @end
 
 #endif  // CHROME_BROWSER_UI_COCOA_INFO_BUBBLE_VIEW_H_