chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Now with proper enum formatting Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

index 2d80a49d020bfcc35a3947a6b023fb623409fb23..2cd7a5df5fcf2dad64e0c64d0a53605ee6409da4 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

@@ -144,7 +144,7 @@ using bookmarks::BookmarkNode;

[BrowserWindowController browserWindowControllerForWindow:parentWindow];

InfoBubbleView* bubble = self.bubble;

- [bubble setArrowLocation:info_bubble::kTopRight];

+ [bubble setArrowLocation:info_bubble::kTopTrailing];

// Insure decent positioning even in the absence of a browser controller,

// which will occur for some unit tests.