DevTools: Highlight DOM node on hover in flamechart.

DevTools: Highlight DOM node on hover in flamechart.

Review-Url: https://codereview.chromium.org/2713363002
Cr-Commit-Position: refs/heads/master@{#453118}
Committed: https://chromium.googlesource.com/chromium/src/+/2d4fa6ef276bb36d958afbee421c0886b954289e

[alph, 2017-02-25 01:39:53]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org

[caseq, 2017-02-25 01:53:57]

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
(right):

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:499:
this._highlightEntry(entryIndex);
let's avoid races of calls to highlightEntry() vs. async completion of
_highlightEntry()

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:509:
return;
moved as much as possible to the sync part?

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:520:
var nodes = await new Promise(fulfill =>
new SDK.DeferredDOMNode(target, backendNodeId).highlight()

[alph, 2017-02-25 01:58:57]

all done

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
(right):

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:499:
this._highlightEntry(entryIndex);
On 2017/02/25 01:53:57, caseq wrote:
> let's avoid races of calls to highlightEntry() vs. async completion of
> _highlightEntry()

Done.

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:509:
return;
On 2017/02/25 01:53:57, caseq wrote:
> moved as much as possible to the sync part?

Done.

https://codereview.chromium.org/2713363002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js:520:
var nodes = await new Promise(fulfill =>
On 2017/02/25 01:53:57, caseq wrote:
> new SDK.DeferredDOMNode(target, backendNodeId).highlight()

Done.

[caseq, 2017-02-25 02:03:08]

lgtm

[alph, 2017-02-25 02:03:26]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-02-25 02:03:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-02-25 02:10:20]

alph@chromium.org changed reviewers:
+ lushnikov@chromium.org

[alph, 2017-02-25 02:10:21]

Lusha, could you please check eslintrc change. Thanks

[alph, 2017-02-25 02:10:32]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-25 02:10:33]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2713363002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-02-25 02:10:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-02-25 02:11:44]

lgtm

[commit-bot: I haz the power, 2017-02-25 03:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 03:22:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2017-02-25 19:02:30]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-02-25 19:02:31]

https://codereview.chromium.org/2713363002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/2713363002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:709:
relatedNodes = await new Promise(fulfill =>
What? As we discussed multiple times, please talk with the team before using new
features.

[pfeldman, 2017-02-26 02:55:08]

> What? As we discussed multiple times, please talk with the team before using
new
> features.

Your comment does not strike me as too respectful, so pointing to
https://www.chromium.org/conduct as something worth reading.

Btw, we did discussed async/await in a broad forum and decided to give it a try
in a couple of changes to see if our framework handles it well.

[alph, 2017-02-26 09:00:34]

I'm proceeding with the patch as per Pavel's comment.

[alph, 2017-02-26 09:00:45]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-26 09:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org,
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2713363002/#ps60001
(title: "fix tests")

[commit-bot: I haz the power, 2017-02-26 09:00:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 10:55:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488099645055440,
"parent_rev": "608b552fd6ba8ba4366e8831631b55bfa29450af", "commit_rev":
"2d4fa6ef276bb36d958afbee421c0886b954289e"}

[commit-bot: I haz the power, 2017-02-26 10:56:04]

Description was changed from

==========
DevTools: Highlight DOM node on hover in flamechart.
==========

to

==========
DevTools: Highlight DOM node on hover in flamechart.

Review-Url: https://codereview.chromium.org/2713363002
Cr-Commit-Position: refs/heads/master@{#453118}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d4fa6ef276bb36d958afbee421c...
==========

[commit-bot: I haz the power, 2017-02-26 10:56:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2d4fa6ef276bb36d958afbee421c...

[alph, 2017-02-28 19:22:59]

Patchset #5 (id:80001) has been deleted