Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-node-reference.html

Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart. (Closed)
Patch Set: fix tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-node-reference.html
diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-node-reference.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-node-reference.html
index 94f83990854e1c6ed5b902f5223086a358939be5..a622930621225a3a3d3be82b56f850319bf5e160 100644
--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-node-reference.html
+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-node-reference.html
@@ -25,20 +25,16 @@ function test()
InspectorTest.evaluateWithTimeline("performActions()", onTimelineRecorded);
});
- function clickValueLink(event, row)
+ async function clickValueLink(event, row)
{
var model = UI.panels.timeline._performanceModel.timelineModel();
- Timeline.TimelineUIUtils.buildTraceEventDetails(event, model, new Components.Linkifier(), true, onDetailsContentReady);
-
- function onDetailsContentReady(element)
- {
- var rows = element.querySelectorAll(".timeline-details-view-row");
- for (var i = 0; i < rows.length; ++i) {
- if (rows[i].firstChild.textContent.indexOf(row) !== -1) {
- rows[i].lastChild.firstChild.shadowRoot.lastChild.click();
- return;
- }
- }
+ var element = await Timeline.TimelineUIUtils.buildTraceEventDetails(event, model, new Components.Linkifier(), true);
+ var rows = element.querySelectorAll(".timeline-details-view-row");
+ for (var i = 0; i < rows.length; ++i) {
+ if (rows[i].firstChild.textContent.indexOf(row) !== -1) {
+ rows[i].lastChild.firstChild.shadowRoot.lastChild.click();
+ return;
+ }
}
}
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/components/flame-chart.html ('k') | third_party/WebKit/Source/devtools/.eslintrc.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698