Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart. (Closed)
Patch Set: fix tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
index 2d334da82dd3f9289c5ed8ec86c39f998c6a3c31..57ddf918da548011ec884ef61ddc9ccdacabe046 100644
--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
@@ -165,12 +165,14 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {
return;
this._highlightedEntryIndex = entryIndex;
this._updateElementPosition(this._highlightElement, this._highlightedEntryIndex);
+ this._dataProvider.highlightEntry(entryIndex);
}
hideHighlight() {
this._entryInfo.removeChildren();
this._highlightedEntryIndex = -1;
this._updateElementPosition(this._highlightElement, this._highlightedEntryIndex);
+ this._dataProvider.highlightEntry(-1);
}
_resetCanvas() {
@@ -1340,6 +1342,11 @@ PerfUI.FlameChartDataProvider.prototype = {
/**
* @param {number} entryIndex
+ */
+ highlightEntry(entryIndex) {},
+
+ /**
+ * @param {number} entryIndex
* @return {boolean}
*/
forceDecoration(entryIndex) {},

Powered by Google App Engine
This is Rietveld 408576698