third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js - Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart. (Closed)

Patch Set: fix tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

index 951b5e0f9aef0de6d778ac3b3a28e7142422cc90..1a719b6a5f0005b99ba5a01999cd61140bc2c198 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js

@@ -113,17 +113,9 @@ Timeline.EventsTimelineTreeView = class extends Timeline.TimelineTreeView {

var traceEvent = node.event;

if (!traceEvent)

return false;

- Timeline.TimelineUIUtils.buildTraceEventDetails(

- traceEvent, this.model().timelineModel(), this._linkifier, false, showDetails.bind(this));

+ Timeline.TimelineUIUtils.buildTraceEventDetails(traceEvent, this.model().timelineModel(), this._linkifier, false)

+ .then(fragment => this._detailsView.element.appendChild(fragment));

return true;

- /**

- * @param {!DocumentFragment} fragment

- * @this {Timeline.EventsTimelineTreeView}

- */

- function showDetails(fragment) {

- this._detailsView.element.appendChild(fragment);

- }

}

/**