third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js - Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

Issue 2713363002: DevTools: Highlight DOM node on hover in flamechart. (Closed)

Patch Set: fix tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/EventsTimelineTreeView.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

index 3242212ccd46de15f00e594e6db532770af55a4c..615df98296c36423572d5200f564d82be6fd8471 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js

@@ -117,8 +117,8 @@ Timeline.TimelineDetailsView = class extends UI.VBox {

case Timeline.TimelineSelection.Type.TraceEvent:

var event = /** @type {!SDK.TracingModel.Event} */ (this._selection.object());

Timeline.TimelineUIUtils.buildTraceEventDetails(

- event, this._model.timelineModel(), this._detailsLinkifier, true,

- this._appendDetailsTabsForTraceEventAndShowDetails.bind(this, event));

+ event, this._model.timelineModel(), this._detailsLinkifier, true)

+ .then(fragment => this._appendDetailsTabsForTraceEventAndShowDetails(event, fragment));

break;

case Timeline.TimelineSelection.Type.Frame:

var frame = /** @type {!TimelineModel.TimelineFrame} */ (this._selection.object());