Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor

Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| to reduce source code size for improving.

Before patch[1], |updateIfNeeded()| is used for doing canonicalization for
existing |VisibleSeleciton|, which is canonicalized before layout tree
modification.

After patch[1], canonicalization is done in |computeVisibleSelectionXXX()|,
which is only the way to get |VisibleSeleciton| from |FrameSelection|.

Thus, callers don't need to call |updateIfNeeded()| explicitly and calling
|updateIfNeeded()| is now redundant.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2712223002
Cr-Commit-Position: refs/heads/master@{#453140}
Committed: https://chromium.googlesource.com/chromium/src/+/baa654ed78967c046f3ea8f8c35948d605ee1a9c

[yosin_UTC9, 2017-02-25 02:03:35]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 02:03:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-25 02:04:31]

Description was changed from

==========
2017-02-25T10:59:38

BUG=
==========

to

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| because this function updates |VisibleSeleciton| cache in
|SelectionEditor| since patch [1] to reduce source code size for improving
code health.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-25 02:13:08]

Description was changed from

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| because this function updates |VisibleSeleciton| cache in
|SelectionEditor| since patch [1] to reduce source code size for improving
code health.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| to reduce source code size for improving.

Before patch[1] |updateIfNeeded()| is used for doing canonicalization for
existing |VisibleSeleciton|, which is canonicalized before layout tree
modification. After patch[1], canonicalization is done in
|computeVisibleSelectionInDomTree()|, which is only the way to get
|VisibleSeleciton| from |FrameSelection|. Thus, callers don't need to call
|updateIfNeeded()| explicitly.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-25 02:15:30]

Description was changed from

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| to reduce source code size for improving.

Before patch[1] |updateIfNeeded()| is used for doing canonicalization for
existing |VisibleSeleciton|, which is canonicalized before layout tree
modification. After patch[1], canonicalization is done in
|computeVisibleSelectionInDomTree()|, which is only the way to get
|VisibleSeleciton| from |FrameSelection|. Thus, callers don't need to call
|updateIfNeeded()| explicitly.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| to reduce source code size for improving.

Before patch[1], |updateIfNeeded()| is used for doing canonicalization for
existing |VisibleSeleciton|, which is canonicalized before layout tree
modification.

After patch[1], canonicalization is done in |computeVisibleSelectionXXX()|,
which is only the way to get |VisibleSeleciton| from |FrameSelection|.

Thus, callers don't need to call |updateIfNeeded()| explicitly and calling
|updateIfNeeded()| is now redundant.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-25 02:15:49]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-25 02:15:49]

PTAL

[Xiaocheng, 2017-02-25 02:45:46]

Almost good with the code change.

https://codereview.chromium.org/2712223002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelection.cpp (left):

https://codereview.chromium.org/2712223002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelection.cpp:1154: void
FrameSelection::updateIfNeeded() {
We should also remove this function from FS.h

[commit-bot: I haz the power, 2017-02-25 04:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 04:16:36]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-02-27 01:58:31]

lgtm

[yosin_UTC9, 2017-02-27 02:11:06]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 02:11:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-27 02:11:34]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-27 02:11:36]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-02-27 02:11:36]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2712223002/#ps20001
(title: "2017-02-27T11:10:27 Remove updateIfNeeded() from FrameSeleciton.h")

[commit-bot: I haz the power, 2017-02-27 02:11:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 03:40:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488161496466710,
"parent_rev": "db29d83db00f668138848dd1ada9be02983690db", "commit_rev":
"baa654ed78967c046f3ea8f8c35948d605ee1a9c"}

[commit-bot: I haz the power, 2017-02-27 03:42:08]

Description was changed from

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| to reduce source code size for improving.

Before patch[1], |updateIfNeeded()| is used for doing canonicalization for
existing |VisibleSeleciton|, which is canonicalized before layout tree
modification.

After patch[1], canonicalization is done in |computeVisibleSelectionXXX()|,
which is only the way to get |VisibleSeleciton| from |FrameSelection|.

Thus, callers don't need to call |updateIfNeeded()| explicitly and calling
|updateIfNeeded()| is now redundant.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Get rid of redundant functions updateIfNeeded() in FrameSelection and
SelectionEditor

This patch gets rid of |updateIfNeeded()| in |FrameSeleciton| and
|SelectionEditor| to reduce source code size for improving.

Before patch[1], |updateIfNeeded()| is used for doing canonicalization for
existing |VisibleSeleciton|, which is canonicalized before layout tree
modification.

After patch[1], canonicalization is done in |computeVisibleSelectionXXX()|,
which is only the way to get |VisibleSeleciton| from |FrameSelection|.

Thus, callers don't need to call |updateIfNeeded()| explicitly and calling
|updateIfNeeded()| is now redundant.

[1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2712223002
Cr-Commit-Position: refs/heads/master@{#453140}
Committed:
https://chromium.googlesource.com/chromium/src/+/baa654ed78967c046f3ea8f8c359...
==========

[commit-bot: I haz the power, 2017-02-27 03:42:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/baa654ed78967c046f3ea8f8c359...