third_party/WebKit/Source/core/editing/SelectionEditor.cpp - Issue 2712223002: Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 2712223002: Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor (Closed)

Patch Set: 2017-02-27T11:10:27 Remove updateIfNeeded() from FrameSeleciton.h Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

index 7d38c7e2e8c82850fc667062453d25067df8ec20..cbf5174bbe79a2e473cd2bfea18c64318f559894 100644

--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp

@@ -375,12 +375,6 @@ bool SelectionEditor::shouldAlwaysUseDirectionalSelection() const {

return frame()->editor().behavior().shouldConsiderSelectionAsDirectional();

}

-void SelectionEditor::updateIfNeeded() {

- // TODO(yosin): We should unify |SelectionEditor::updateIfNeeded()| and

- // |updateCachedVisibleSelectionIfNeeded()|

- updateCachedVisibleSelectionIfNeeded();

bool SelectionEditor::needsUpdateVisibleSelection() const {

return m_cacheIsDirty || m_styleVersion != document().styleVersion();

}