Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor

third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 1866 matching lines @@
 static bool enabledCut(LocalFrame& frame, Event*, EditorCommandSource source) {
   if (!canWriteClipboard(frame, source))
     return false;
   return frame.editor().canDHTMLCut() || frame.editor().canCut();
 }
 
 static bool enabledInEditableText(LocalFrame& frame,
                                   Event* event,
                                   EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
-  // We should update selection to canonicalize with current layout and style,
-  // before accessing |FrameSelection::selection()|.
-  frame.selection().updateIfNeeded();
   return frame.editor().selectionForCommand(event).rootEditableElement();
 }
 
 static bool enabledDelete(LocalFrame& frame,
                           Event* event,
                           EditorCommandSource source) {
   switch (source) {
     case CommandFromMenuOrKeyBinding:
       return frame.editor().canDelete();
     case CommandFromDOM:
       // "Delete" from DOM is like delete/backspace keypress, affects selected
       // range if non-empty, otherwise removes a character
       return enabledInEditableText(frame, event, source);
   }
   NOTREACHED();
   return false;
 }
 
 static bool enabledInRichlyEditableText(LocalFrame& frame,
                                         Event*,
                                         EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
-  // We should update selection to canonicalize with current layout and style,
-  // before accessing |FrameSelection::selection()|.
-  frame.selection().updateIfNeeded();
   return !frame.selection()
               .computeVisibleSelectionInDOMTreeDeprecated()
               .isNone() &&
          frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .isContentRichlyEditable() &&
          frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .rootEditableElement();
 }
 
 static bool enabledPaste(LocalFrame& frame,
                          Event*,
                          EditorCommandSource source) {
   if (!canReadClipboard(frame, source))
     return false;
   return frame.editor().canPaste();
 }
 
 static bool enabledRangeInEditableText(LocalFrame& frame,
                                        Event*,
                                        EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
-  // We should update selection to canonicalize with current layout and style,
-  // before accessing |FrameSelection::selection()|.
-  frame.selection().updateIfNeeded();
   return frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .isRange() &&
          frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .isContentEditable();
 }
 
 static bool enabledRangeInRichlyEditableText(LocalFrame& frame,
                                              Event*,
                                              EditorCommandSource) {
   frame.document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
-  // We should update selection to canonicalize with current layout and style,
-  // before accessing |FrameSelection::selection()|.
-  frame.selection().updateIfNeeded();
   return frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .isRange() &&
          frame.selection()
              .computeVisibleSelectionInDOMTreeDeprecated()
              .isContentRichlyEditable();
 }
 
 static bool enabledRedo(LocalFrame& frame, Event*, EditorCommandSource) {
   return frame.editor().canRedo();
@@ skipping 796 matching lines @@
           *m_frame, DirectionBackward, WordGranularity);
     case WebEditingCommandType::DeleteWordForward:
       return RangesFromCurrentSelectionOrExtendCaret(*m_frame, DirectionForward,
                                                      WordGranularity);
     default:
       return targetRangesForInputEvent(*target);
   }
 }
 
 }  // namespace blink