third_party/WebKit/Source/core/editing/FrameSelection.h - Issue 2712223002: Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2712223002: Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor (Closed)

Patch Set: 2017-02-27T11:10:27 Remove updateIfNeeded() from FrameSeleciton.h Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.h

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h

index d78e98af7b559247bc54b9a056385d56c6c036f9..cb803784fbdb18804560a312a144071f83f0d65b 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.h

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h

@@ -269,12 +269,6 @@ class CORE_EXPORT FrameSelection final

bool shouldShowBlockCursor() const;

void setShouldShowBlockCursor(bool);

- // TODO(yosin): We should check DOM tree version and style version in

- // |FrameSelection::selection()| to make sure we use updated selection,

- // rather than having |updateIfNeeded()|. Once, we update all layout tests

- // to use updated selection, we should make |updateIfNeeded()| private.

- void updateIfNeeded();

void cacheRangeOfDocument(Range*);

Range* documentCachedRange() const;

void clearDocumentCachedRange();