Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2712223002: Get rid of redundant functions updateIfNeeded() in FrameSelection and SelectionEditor (Closed)
Patch Set: 2017-02-27T11:10:27 Remove updateIfNeeded() from FrameSeleciton.h Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 // a case of RangeSelection. crbug.com/443061 262 // a case of RangeSelection. crbug.com/443061
263 void revealSelection( 263 void revealSelection(
264 const ScrollAlignment& = ScrollAlignment::alignCenterIfNeeded, 264 const ScrollAlignment& = ScrollAlignment::alignCenterIfNeeded,
265 RevealExtentOption = DoNotRevealExtent); 265 RevealExtentOption = DoNotRevealExtent);
266 void setSelectionFromNone(); 266 void setSelectionFromNone();
267 267
268 void updateAppearance(); 268 void updateAppearance();
269 bool shouldShowBlockCursor() const; 269 bool shouldShowBlockCursor() const;
270 void setShouldShowBlockCursor(bool); 270 void setShouldShowBlockCursor(bool);
271 271
272 // TODO(yosin): We should check DOM tree version and style version in
273 // |FrameSelection::selection()| to make sure we use updated selection,
274 // rather than having |updateIfNeeded()|. Once, we update all layout tests
275 // to use updated selection, we should make |updateIfNeeded()| private.
276 void updateIfNeeded();
277
278 void cacheRangeOfDocument(Range*); 272 void cacheRangeOfDocument(Range*);
279 Range* documentCachedRange() const; 273 Range* documentCachedRange() const;
280 void clearDocumentCachedRange(); 274 void clearDocumentCachedRange();
281 275
282 DECLARE_TRACE(); 276 DECLARE_TRACE();
283 277
284 private: 278 private:
285 friend class CaretDisplayItemClientTest; 279 friend class CaretDisplayItemClientTest;
286 friend class FrameSelectionTest; 280 friend class FrameSelectionTest;
287 friend class PaintControllerPaintTestForSlimmingPaintV1AndV2; 281 friend class PaintControllerPaintTestForSlimmingPaintV1AndV2;
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 330
337 } // namespace blink 331 } // namespace blink
338 332
339 #ifndef NDEBUG 333 #ifndef NDEBUG
340 // Outside the WebCore namespace for ease of invocation from gdb. 334 // Outside the WebCore namespace for ease of invocation from gdb.
341 void showTree(const blink::FrameSelection&); 335 void showTree(const blink::FrameSelection&);
342 void showTree(const blink::FrameSelection*); 336 void showTree(const blink::FrameSelection*);
343 #endif 337 #endif
344 338
345 #endif // FrameSelection_h 339 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698